[refactoring] generic check command with filtering support by businessbean · Pull Request #2 · sapcc/concourse-netbox-resource

businessbean · 2025-06-26T11:50:59Z

official netbox library used
check command with filter support
in,out command currently only noop
(unit) tests rewritten
Container image creation updated and documented
Golang image for the build stage
Distroless base without libc and shell for the final image
Concourse config documented
Github workflow for image build and release added
workflow documentation added
CODEOWNERS added

Nuckal777

In my opinion, all cobra stuff can be left out. We're not building a tool for interactive use here. Upstream resources also only check os.Args, e.g. here.

Dockerfile

cmd/in/main.go

go.mod

cmd/out/main.go

pkg/netbox/query.go

businessbean · 2025-08-19T15:58:09Z

In my opinion, all cobra stuff can be left out. We're not building a tool for interactive use here. Upstream resources also only check os.Args, e.g. here.

That's a good idea. I have replaced cobra with flag to simplify the code...

cmd/check/main.go

cmd/check/main_test.go

cmd/check/main.go

cmd/out/main.go

cmd/out/main_test.go

pkg/helper/tests.go

SchwarzM

lgtm

internal/app/check.go

internal/app/check_test.go

internal/app/in.go

internal/app/in_test.go

internal/app/out.go

internal/app/out_test.go

internal/helper/tests.go

internal/netbox/query.go

Nuckal777

My last nitpicks.

internal/app/check_test.go

internal/app/in_test.go

internal/app/out_test.go

- official netbox library used - check command with filter support - in,out command currently only noop - (unit) tests rewritten - Container image creation updated and documented - Golang image for the build stage - Distroless base without libc and shell for the final image - Concourse config documented - Github workflow for image build and release added - workflow actions versions pinned - workflow documentation added - CODEOWNERS added

SchwarzM

lgtm

businessbean requested review from Nuckal777 and SchwarzM June 26, 2025 11:51

businessbean force-pushed the refactor-go-netbox branch 2 times, most recently from 17c005e to 93fc07c Compare June 27, 2025 06:31

businessbean force-pushed the refactor-go-netbox branch from 93fc07c to a470879 Compare July 30, 2025 15:30

Nuckal777 reviewed Aug 5, 2025

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

cmd/in/main.go Outdated Show resolved Hide resolved

go.mod Outdated Show resolved Hide resolved

cmd/out/main.go Outdated Show resolved Hide resolved

pkg/netbox/query.go Show resolved Hide resolved

businessbean force-pushed the refactor-go-netbox branch from a470879 to 3afd477 Compare August 19, 2025 15:55

businessbean force-pushed the refactor-go-netbox branch 2 times, most recently from c696f43 to b652ac4 Compare August 26, 2025 12:24

businessbean marked this pull request as draft September 1, 2025 08:58

businessbean force-pushed the refactor-go-netbox branch from 3a68eb1 to 9274df6 Compare September 2, 2025 20:11

businessbean marked this pull request as ready for review September 2, 2025 20:24

businessbean requested a review from Nuckal777 September 2, 2025 20:24

businessbean force-pushed the refactor-go-netbox branch 16 times, most recently from 13b0071 to 6a19f2b Compare September 5, 2025 10:51

businessbean force-pushed the refactor-go-netbox branch 2 times, most recently from b848d97 to 8040939 Compare September 5, 2025 11:52

businessbean force-pushed the refactor-go-netbox branch from 8040939 to 6c57264 Compare September 18, 2025 18:56

Nuckal777 requested changes Sep 23, 2025

View reviewed changes

businessbean force-pushed the refactor-go-netbox branch 4 times, most recently from 78f8499 to 4ce14d4 Compare September 29, 2025 12:24

businessbean requested a review from Nuckal777 September 29, 2025 12:26

businessbean force-pushed the refactor-go-netbox branch from 4ce14d4 to 2f030b8 Compare October 29, 2025 21:17

SchwarzM previously approved these changes Oct 30, 2025

View reviewed changes

Nuckal777 requested changes Nov 7, 2025

View reviewed changes

businessbean dismissed SchwarzM’s stale review via 5c864a8 November 13, 2025 13:06

businessbean force-pushed the refactor-go-netbox branch from 2f030b8 to 5c864a8 Compare November 13, 2025 13:06

businessbean requested a review from Nuckal777 November 13, 2025 13:48

Nuckal777 reviewed Nov 14, 2025

View reviewed changes

internal/app/check_test.go Outdated Show resolved Hide resolved

internal/app/in_test.go Outdated Show resolved Hide resolved

internal/app/out_test.go Outdated Show resolved Hide resolved

businessbean force-pushed the refactor-go-netbox branch from 5c864a8 to cacab4e Compare November 17, 2025 09:22

businessbean requested a review from Nuckal777 November 17, 2025 09:22

Nuckal777 approved these changes Nov 17, 2025

View reviewed changes

businessbean requested a review from SchwarzM November 17, 2025 09:36

SchwarzM approved these changes Nov 17, 2025

View reviewed changes

businessbean merged commit f55806c into master Nov 17, 2025
4 checks passed

Conversation

businessbean commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nuckal777 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

businessbean commented Aug 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SchwarzM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nuckal777 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SchwarzM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

businessbean commented Jun 26, 2025 •

edited

Loading