Additional query filters, parallel queries and changelog query added

[businessbean]

• region_name, tenant and tag properties added to the query filter
• device_site, device_region and device_tags properties added to the version output
• use_changelog option added to use the NetBox changelog. See the documentation for details and performance considerations
• parallel_queries option added to speed up the check process by running multiple queries in parallel
• golang version updated to 1.25.7

[majewsky]

This uses several outdated idioms. Please check the suggestions generated by go fix ./... under Go 1.26.

[businessbean]

This uses several outdated idioms. Please check the suggestions generated by go fix ./... under Go 1.26.

Hi Stefan, thanks for the hint. I will check that in a later change together with the update to 1.26.x

[majewsky]

If you are still on Go 1.25, you can do the same as golangci-lint run --enable modernize --fix. That is what was moved into the core toolchain as go fix in 1.26

[majewsky]

Working through my notification backlog, and finally got to this again.

[majewsky]

Indentation looks weird here. Probably a mix of tabs and spaces that displays inconsistently.

[majewsky]

Suggested change

	result, err := populateDeviceDetails(helper.DeviceName, input, currentDevice, nil, context.Background())
	result, err := populateDeviceDetails(helper.DeviceName, input, currentDevice, nil, t.Context())

[majewsky]

This variable is not declared locally, so it writes into the global variable, which does not seem intentional. Either a local variable should be declared, or the non-error return values should be removed if the intent is to write directly into the global variables.

Same for referenceTime further below.

[majewsky]

In the err != nil case, the error is discarded silently. Either it should be handled explicitly in some way, or if a panic is fine, this can be shortened to

Suggested change

	if configContextBytes, err := json.Marshal(configContextData); err == nil {
	configContext = string(configContextBytes)
	}
	configContext = string(must.Return(json.Marshal(configContextData)))

using https://pkg.go.dev/github.com/sapcc/go-bits/must#Return.

[majewsky]

Suggested change

	if configured <= 0 {
	return 1
	}
	return configured
	return max(configured, 1)

And then this can possibly be inlined.

[majewsky]

Suggested change

	regions := make([]string, 0, len(regionSet))
	for region := range regionSet {
	regions = append(regions, region)
	}
	return regions
	return slices.Collect(maps.Keys(regionSet))

[majewsky]

Delete this whole function and write only siteRegionCache[siteId] instead. A nil map behaves like an empty map during lookups, and a failed lookup defaults to the zero value.