Support project_domain_name instead of user_domain_name in iaas_filter#12
Open
rajivmucheli wants to merge 3 commits intostable/2024.2-m3from
Open
Support project_domain_name instead of user_domain_name in iaas_filter#12rajivmucheli wants to merge 3 commits intostable/2024.2-m3from
rajivmucheli wants to merge 3 commits intostable/2024.2-m3from
Conversation
also move the if iaas_filter above since its applied to all domains fix imageproxy error in show(), .get is not supported
rajivmucheli
changed the title
| # starts with 'iaas' as a hard tenant-level policy enforcement. | ||
| user_domain_name = getattr(req.context, 'user_domain_name', None) | ||
| LOG.debug("[IAAS_FILTER] Effective user_domain_name: %s", user_domain_name) | ||
| project_domain_name = getattr(req.context, 'project_domain_name', None) |
There was a problem hiding this comment.
Did you check that the context always contains this value? Because it didn't for me, so I had to use the context''s project_id to fetch the domain from Keystone.
If we rely on this being there, but it isn't always, then some users (maybe application credentials? idk) can circumvent this check.
Author
There was a problem hiding this comment.
yes, as discussed internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also move the if iaas_filter above since its applied to all domains
fix imageproxy error in show(), .get is not supported