[SAP] allow images of all visibility in iaas filter

[rajivmucheli]

No description provided.

[joker-at-work]

Do I get it right that external customers can see public images now if they request them? They still can't show them and thus (hopefully) use them, thogh?

It would be helpful if you'd provide a reason for this change in the commit-message.

[joker-at-work]

Did this provide problems and that's why we're switching to getattr()?

Otherwise, it's the same just that you moved == 'public' into the condition, right?

[rajivmucheli]

strange observation was

1. os image list doesnt list all images in iaas domains.
2. based on few tests, in the iaas domains, private images after 7 days from creation doesnt show up by default os image list, the images can be listed only after specifying flag os image list --private, etc
3. i also looked in the openstackclient to check if there was anything default set, but there wasnt.
4. This commit is to fix to list all images with visibility private, shared, community in the iaas domains. If this is possible, elektra will list the images, else its missing after 7 days.
5. switching to project_domain_name is on hold, since we may need access manage images for sometime.
6. I am unsure if application_credentials code needs to be looked into this, based on recent tests, the application creds used to create images have no expiry date set.

[joker-at-work]

But openstack image list --public sets and explicit visibility and thus skips the whole filtering if afaics. Am I looked at it wrong?