move Category to liquid and introduce Category.DisplayName#81
Merged
Conversation
majewsky
requested changes
Feb 24, 2026
wagnerd3
force-pushed
the
move_category
branch
from
7ecab30 to
44c60bb
Compare
majewsky
requested changes
Feb 26, 2026
Contributor
majewsky
left a comment
majewsky
left a comment
There was a problem hiding this comment.
A few more small points:
wagnerd3
force-pushed
the
move_category
branch
from
44c60bb to
1c58cb3
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
majewsky
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When filing sapcc/limes#839, I noticed that we make heavy use of the
ResourceInfo.Categorywhich is currently part oflimesresources. The problem with that is many display names are ambiguous, if you ignore theCategory. This makes the liquids configuration kind of invalid on its own, because it relies on theCategoryto be added in Limes.In order to solve this, we:
DisplayNameon the Category to be shown to users, similar toResourceInfo, RateInfo, ServiceInfo