move ForeachOptionTypeInLiquid from go-bits to here#82
Merged
Conversation
When we added new relevant option types in 1.20.0, we did not notice the breakage in the ForeachOptionTypeInLiquid test until it hit us in prod. To avoid this going forward, this moves the function into here, so that new relevant types fail loudly and immediately. This is a straight port of the relevant parts of <https://github.com/sapcc/go-bits/blob/master/liquidapi/liquidapi.go> <https://github.com/sapcc/go-bits/blob/master/liquidapi/liquidapi_test.go> The only significant change is that the test helper function getOptionTypesRecursively uses go-bits/logg, which is not possible here. I gave it an extra `t *testing.T` argument and replaced `logg.Error` with `t.Errorf`.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
wagnerd3
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we added new relevant option types in 1.20.0, we did not notice the breakage in the ForeachOptionTypeInLiquid test until it hit us in prod. To avoid this going forward, this moves the function into here, so that new relevant types fail loudly and immediately.
This is a straight port of the relevant parts of
https://github.com/sapcc/go-bits/blob/master/liquidapi/liquidapi.go https://github.com/sapcc/go-bits/blob/master/liquidapi/liquidapi_test.go
The only significant change is that the test helper function getOptionTypesRecursively uses go-bits/logg, which is not possible here. I gave it an extra
t *testing.Targument and replacedlogg.Errorwitht.Errorf.When merged, I intend to remove the now-duplicate implementation in go-bits and have it call this implementation.