Skip to content

Remove outdated, pre-installed shellcheck #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nuckal777 merged 1 commit into from
Aug 12, 2025
Merged

Remove outdated, pre-installed shellcheck #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:
uses: golangci/golangci-lint-action@v8
with:
version: latest
- name: Delete pre-installed shellcheck
run: sudo rm -f $(which shellcheck)
- name: Run shellcheck
run: make run-shellcheck
- name: Dependency Licenses Review
Expand Down
5 changes: 5 additions & 0 deletions internal/ghworkflow/workflow_checks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ func checksWorkflow(cfg core.Configuration) {
})

if cfg.ShellCheck.Enabled.UnwrapOr(true) {
// delete the pretty out of date installed version of shellcheck so that make install-shellcheck installs the current version
j.addStep(jobStep{
Name: "Delete pre-installed shellcheck",
Run: "sudo rm -f $(which shellcheck)",
})
j.addStep(jobStep{
Name: "Run shellcheck",
Run: "make run-shellcheck",
Expand Down
Loading