fix the variable override mechanism#362
Merged
SuperSandro2000 merged 1 commit intomainfrom Sep 4, 2025
Merged
Conversation
majewsky
requested review from
Nuckal777,
SuperSandro2000,
VoigtS and
wagnerd3
as code owners
The override mechanism proposed by @stanislav-zaprudskiy in #352 is problematic because --warn-undefined-variables makes noise about it: ```shellSession $ make Makefile:67: warning: undefined variable 'GO_BUILDFLAGS' Makefile:68: warning: undefined variable 'GO_LDFLAGS' Makefile:69: warning: undefined variable 'GO_TESTFLAGS' Makefile:70: warning: undefined variable 'GO_TESTENV' Makefile:71: warning: undefined variable 'GO_BUILDENV' env go build -mod vendor -ldflags '-s -w ... ``` However, through much experimentation, I discovered that the += operator behaves in the intended way, as documented in the new generated comment.
majewsky
force-pushed
the
better-variable-overrides
branch
from
17a8dc7 to
f56b186
Compare
Contributor
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
SuperSandro2000
approved these changes
Sep 4, 2025
VoigtS
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The override mechanism proposed by @stanislav-zaprudskiy in #352 is problematic because --warn-undefined-variables makes noise about it:
However, through much experimentation, I discovered that the += operator behaves in the intended way, as documented in the new generated comment.