Skip to content

dockerfile: add extraBuildDirectives for directives at build stage#371

Merged
majewsky merged 3 commits intomainfrom
add-dockerfile-extraBuildDirectives
Sep 24, 2025
Merged

dockerfile: add extraBuildDirectives for directives at build stage#371
majewsky merged 3 commits intomainfrom
add-dockerfile-extraBuildDirectives

Conversation

@notandy
Copy link
Copy Markdown
Contributor

@notandy notandy commented Sep 18, 2025

This PR adds the dockerfile: config option extraBuildDirectives, which
adds additional docker directives at the end of the build stage.

Motiviation is to change the certificate-chain, e.g. add additional
certificates since they are generated only during build time and then
copied to the final container.

This PR adds the dockerfile: config option `extraBuildDirectives`, which
adds additional docker directives at the end of the build stage.

Motiviation is to change the certificate-chain, e.g. add addition
certificates since they are generated only during build time and then
copied to the final container.
@notandy notandy force-pushed the add-dockerfile-extraBuildDirectives branch from cf94307 to 179a778 Compare September 18, 2025 20:52
majewsky
majewsky previously approved these changes Sep 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/go-makefile-maker/internal/core 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/go-makefile-maker/internal/core/config.go 0.00% (ø) 34 0 34

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@majewsky majewsky merged commit 1096ab1 into main Sep 24, 2025
7 of 8 checks passed
@majewsky majewsky deleted the add-dockerfile-extraBuildDirectives branch September 24, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants