Skip to content

revert recent changes to variable assignments#373

Merged
majewsky merged 1 commit intomainfrom
revert-variable-changes
Sep 23, 2025
Merged

revert recent changes to variable assignments#373
majewsky merged 1 commit intomainfrom
revert-variable-changes

Conversation

@majewsky
Copy link
Copy Markdown
Contributor

@majewsky majewsky commented Sep 23, 2025

This reverts commit d3da286 and 8f69811.

These commits seem to have been made without understanding how the variable mechanism is supposed to work. They also invalidate the documentation that's right next to the changed lines.

This reverts commit d3da286 and
8f69811.

These commits seem to have been made without understanding how the
variable mechanism is supposed to work.
@majewsky majewsky force-pushed the revert-variable-changes branch from 5d39be8 to cc38e71 Compare September 23, 2025 09:46
@github-actions
Copy link
Copy Markdown
Contributor

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/go-makefile-maker/internal/makefile 8.00% (-0.02%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/go-makefile-maker/internal/makefile/makefile.go 0.00% (ø) 196 (+1) 0 196 (+1)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@majewsky majewsky merged commit c0873cb into main Sep 23, 2025
8 checks passed
@majewsky majewsky deleted the revert-variable-changes branch September 23, 2025 09:50
@stanislav-zaprudskiy
Copy link
Copy Markdown
Contributor

These commits seem to have been made without understanding how the variable mechanism is supposed to work. They also invalidate the documentation that's right next to the changed lines.

You may want to update the originally intended and documented behavior as well to reflect the current behavior -

go-makefile-maker/README.md

Lines 458 to 470 in 18ddcb2

When invoking the respective targets utilizing the variables, it's possible to either append to the provided values by modifying the calling environment:
```console
$ GO_BUILDFLAGS="-work -v" make build/go-makefile-maker
env go build -mod vendor -work -v -ldflags ...
```
or to override their values by passing the variables as `make` arguments:
```console
$ make build/go-makefile-maker GO_BUILDFLAGS="-mod=mod"
env go build -mod=mod -ldflags ...
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants