explicitly reject the ancient make version shipped by macOS#376
Merged
Conversation
Mac users should install a newer make via Homebrew etc.
majewsky
requested review from
Nuckal777,
SuperSandro2000,
VoigtS and
wagnerd3
as code owners
Makefile
Outdated
| # macOS ships with make 3.81 from 2006, which does not support all the stuff that we need | ||
| ifeq ($(MAKE_VERSION),3.81) | ||
| ifeq (,$(shell which gmake 2>/dev/null)) | ||
| $(error We do not support "make" versions that are two decades old. Please install a newer version, e.g. using "brew install make") |
Member
There was a problem hiding this comment.
Suggested change
| $(error We do not support "make" versions that are two decades old. Please install a newer version, e.g. using "brew install make") | |
| $(error We do not support "make" version $(MAKE_VERSION) that are two decades old. Please install a newer version, e.g. using "brew install make" and run it via "gmake".) |
Contributor
Author
There was a problem hiding this comment.
I agree with the first part, and have applied it.
I disagree with the second part. Inevitably, Homebrew will change how they install make, and this comment will become incorrect. Also, this part of the comment may not apply when installing make through any other method, such as Nix. I specifically included the version for when gmake is installed, in case that whatever the user uses installs gmake and not make.
majewsky
force-pushed
the
old-make-unsupported
branch
from
2adc275 to
b2a8092
Compare
Contributor
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
SuperSandro2000
approved these changes
Sep 23, 2025
VoigtS
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac users should install a newer make via Homebrew etc.