Skip to content

fix make install-shellcheck on macOS#378

Merged
VoigtS merged 1 commit intomainfrom
fix-shellcheck-download-on-mac
Sep 24, 2025
Merged

fix make install-shellcheck on macOS#378
VoigtS merged 1 commit intomainfrom
fix-shellcheck-download-on-mac

Conversation

@majewsky
Copy link
Copy Markdown
Contributor

@majewsky majewsky commented Sep 23, 2025

It generated the wrong download URL:

- https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.macos.arm64.tar.xz
+ https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.darwin.aarch64.tar.xz

Fixes #377.

@github-actions
Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/go-makefile-maker/internal/makefile 8.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/go-makefile-maker/internal/makefile/makefile.go 0.00% (ø) 196 0 196

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@VoigtS VoigtS merged commit 4ed79eb into main Sep 24, 2025
8 checks passed
@SuperSandro2000 SuperSandro2000 deleted the fix-shellcheck-download-on-mac branch October 8, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make install-shellcheck does not work on plain MacOS

3 participants