Add docker test target which can be easily run in concourse#391
Merged
Add docker test target which can be easily run in concourse#391
Conversation
SuperSandro2000
force-pushed
the
docker-test-target
branch
9 times, most recently
from
5208e94 to
3fabf7c
Compare
SuperSandro2000
requested review from
Nuckal777,
VoigtS,
majewsky and
wagnerd3
as code owners
SuperSandro2000
force-pushed
the
docker-test-target
branch
from
3fabf7c to
00a1259
Compare
majewsky
requested changes
Oct 16, 2025
SuperSandro2000
force-pushed
the
docker-test-target
branch
2 times, most recently
from
76897ff to
a7e20f6
Compare
SuperSandro2000
force-pushed
the
docker-test-target
branch
2 times, most recently
from
e9d1106 to
4f0313b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
majewsky
requested changes
Nov 5, 2025
Contributor
majewsky
left a comment
majewsky
left a comment
There was a problem hiding this comment.
There should be a way to give custom environment variables to the make check call. For the go-makefile-maker --autoupdate-deps runs, we need to give CHECK_SKIPS_FUNCTIONAL_TEST=true.
SuperSandro2000
force-pushed
the
docker-test-target
branch
from
4f0313b to
0a50250
Compare
Member
Author
|
Contributor
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
majewsky
approved these changes
Nov 11, 2025
This was referenced Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see sapcc/keppel#604 and sapcc/limes#784