docker test target: chown instead of chmod, cover /go/ as well#408
Merged
SuperSandro2000 merged 1 commit intomainfrom Nov 12, 2025
Merged
docker test target: chown instead of chmod, cover /go/ as well#408SuperSandro2000 merged 1 commit intomainfrom
SuperSandro2000 merged 1 commit intomainfrom
Conversation
It is unclear why we initially opted for `chmod 777`, but since we run the remainder of this stage as appuser:appgroup, it feels cleaner to me to `chown` to that user instead. The addition of `/go/` here is intended to fix this error observed in the wild in Limes: ``` Step 15/27 : RUN cd /src && git config --global --add safe.directory /src && make build/cover.out ---> Running in f340e685fcd7 go: writing stat cache: open /go/pkg/mod/cache/download/github.com/sapcc/limes/@v/v0.0.0-20251112155133-bda68ff48b83.info241674416.tmp: permission denied ```
majewsky
requested review from
Nuckal777,
SuperSandro2000,
VoigtS and
wagnerd3
as code owners
SuperSandro2000
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is unclear why we initially opted for
chmod 777, but since we run the remainder of this stage as appuser:appgroup, it feels cleaner to me tochownto that user instead.The addition of
/go/here is intended to fix this error observed in the wild in Limes: