Skip to content

add .idea to .dockerignore #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
notandy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add .idea to .dockerignore #423

notandy wants to merge 1 commit into from

Conversation

@notandy
Copy link
Contributor

@notandy notandy commented Dec 1, 2025 •
edited
Loading

  • [.dockerignore] add .idea/ to default .dockerignore

@notandy notandy changed the title fixes add .idea to .dockerignore, set env CHECK_SKIPS_FUNCTIONAL_TEST=true for docker test Dec 1, 2025
majewsky
majewsky requested changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I did not get to send PR for Archer yet. CHECK_SKIPS_FUNCTIONAL_TEST is already an outdated pattern, because we changed the go-makefile-maker CI to instead run docker build --target test. So this variable can be set within the Makefile.maker.yaml of Archer like this, and does not need to be a centrally-defined magic variable anymore.

The .idea change is fine.

@notandy notandy changed the title add .idea to .dockerignore, set env CHECK_SKIPS_FUNCTIONAL_TEST=true for docker test add .idea to .dockerignore Dec 2, 2025
@notandy
Copy link
Contributor Author

notandy commented Dec 2, 2025

Sorry that I did not get to send PR for Archer yet. CHECK_SKIPS_FUNCTIONAL_TEST is already an outdated pattern, because we changed the go-makefile-maker CI to instead run docker build --target test. So this variable can be set within the Makefile.maker.yaml of Archer like this, and does not need to be a centrally-defined magic variable anymore.

The .idea change is fine.

ok thanks, I've dropped the CHECK_SKIPS_FUNCTIONAL_TEST commit.

@notandy notandy requested a review from majewsky December 2, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 is a code owner

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS is a code owner

@wagnerd3 wagnerd3 Awaiting requested review from wagnerd3 wagnerd3 is a code owner

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777 Nuckal777 is a code owner

@majewsky majewsky Awaiting requested review from majewsky majewsky is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@notandy @majewsky