Skip to content

add .idea to .dockerignore#423

Merged
majewsky merged 1 commit intomainfrom
fixes
Dec 9, 2025
Merged

add .idea to .dockerignore#423
majewsky merged 1 commit intomainfrom
fixes

Conversation

@notandy
Copy link
Contributor

@notandy notandy commented Dec 1, 2025 •
edited
Loading

  • [.dockerignore] add .idea/ to default .dockerignore

@notandy notandy changed the title fixes add .idea to .dockerignore, set env CHECK_SKIPS_FUNCTIONAL_TEST=true for docker test Dec 1, 2025
majewsky
majewsky requested changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I did not get to send PR for Archer yet. CHECK_SKIPS_FUNCTIONAL_TEST is already an outdated pattern, because we changed the go-makefile-maker CI to instead run docker build --target test. So this variable can be set within the Makefile.maker.yaml of Archer like this, and does not need to be a centrally-defined magic variable anymore.

The .idea change is fine.

@notandy notandy changed the title add .idea to .dockerignore, set env CHECK_SKIPS_FUNCTIONAL_TEST=true for docker test add .idea to .dockerignore Dec 2, 2025
@notandy
Copy link
Contributor Author

notandy commented Dec 2, 2025

Sorry that I did not get to send PR for Archer yet. CHECK_SKIPS_FUNCTIONAL_TEST is already an outdated pattern, because we changed the go-makefile-maker CI to instead run docker build --target test. So this variable can be set within the Makefile.maker.yaml of Archer like this, and does not need to be a centrally-defined magic variable anymore.

The .idea change is fine.

ok thanks, I've dropped the CHECK_SKIPS_FUNCTIONAL_TEST commit.

@notandy notandy requested a review from majewsky December 2, 2025 15:47
@majewsky majewsky merged commit f8a091f into main Dec 9, 2025
8 checks passed
@majewsky majewsky deleted the fixes branch December 9, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majewsky majewsky majewsky approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@VoigtS VoigtS Awaiting requested review from VoigtS

@wagnerd3 wagnerd3 Awaiting requested review from wagnerd3

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notandy @majewsky