Draft
Conversation
Member
Author
|
The alternative to that I had in mind would be to move that logic out of the helm charts and add a generator in our configuration repo to generate all the variants, and have this chart just render the values for the flavors (like this). I mean, I would intend to move the values out of the chart into the configuration repo anyway, but the question here is more how much logic should be in this chart. |
This fixes two inconsistencies: - hana_c24_m365: Adds 'vmware:evc_mode': 'intel-cascadelake' - m1.10xlargesmallcpu_v2: Adds 'trait:CUSTOM_HW_SAPPHIRE_RAPIDS': 'required'
fwiesel
force-pushed
the
sap_seeds_kvm
branch
from
bea5a27 to
a807f8a
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.