More vmware image

[fwiesel]

No description provided.

[fwiesel]

Follow up to #571. I am not 100% sure about the impact, hence rather a draft.

[joker-at-work]

Maybe we can use _get_instance_config_info() instead? It seems to return the vi we see often used with vi.ii.

[fwiesel]

_get_instance_config_info also calls _get_vm_config_info which involves many other calls.
I think, we can probably refactor some more code where we need the datastore to be selected, but again, I'd rather would do that in a separate change. It is easily changed in the code, but the tests need adopted as well.

[joker-at-work]

Another separate change? I thought this PR was the separate change already :D

[fwiesel]

Well, it also was the one with VMwareImage. That change I can do easily, as it is a minimal change.
_get_instance_config_info looks much more involved, and I am not sure, I can actually implement it quickly, and I might not even do it before my PTO.

[joker-at-work]

We have a quick-fix in, so I'd be fine with a proper fix later instead of another one next week which we have to update again.

If we say we go with VMwareImage directly, that's fine by me, too. I wanted to raise awareness how other code does it and if that's maybe the better option.

[fwiesel]

I agree, it is likely better in several places, because there they also do the same calls as _get_instance_config_info, but not necessarily all of them.