Fix YAML test suite case 4H7K (extra closing bracket should fail)#92
Open
bourumir-wyngs wants to merge 3 commits intosaphyr-rs:masterfrom
Open
Fix YAML test suite case 4H7K (extra closing bracket should fail)#92bourumir-wyngs wants to merge 3 commits intosaphyr-rs:masterfrom
bourumir-wyngs wants to merge 3 commits intosaphyr-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes the sequence like
[ a, b, c ] ]to fail with scan error. This is not valid YAML, and there is a case 4H7K in yaml test suite checking that parsing results in error. saphyr-parser 0.0.6 swallows this YAML as valid.This patch does not cause regressions in any of 624 cases in saphyr-rs neither in 702 case tests in serde-saphyr.