Skip to content
This repository was archived by the owner on Nov 14, 2025. It is now read-only.

Conversation

@sapientpants
Copy link
Owner

Summary

Removes an unnecessary build step from the main workflow that was running before version management.

Changes

  • ✅ Removed redundant "Build for changeset" step from main.yml
  • ✅ Cleaned up orphaned dist/dev directory containing stale build artifacts
  • ✅ Workflow validation passes (actionlint)

Rationale

The removed build step was unnecessary because:

  • The changeset system uses the npm package changelog-github-custom, not local TypeScript code
  • The misleading comment claimed a custom changelog needed to be built, but it's actually an npm dependency
  • The second build step (after version detection) handles all actual build requirements

Impact

  • 🚀 Reduces CI pipeline execution time by ~30 seconds on each main branch push
  • 📦 Simplifies the workflow by removing redundant operations
  • 🧹 Cleans up stale build artifacts that weren't being used

Testing

  • ✅ Workflow syntax validated with actionlint
  • ✅ Changeset version command tested locally (works without the build)
  • ✅ All pre-commit hooks pass

- Removed unnecessary 'Build for changeset' step that was building before
  version management
- The changeset system uses the npm package 'changelog-github-custom', not
  local TypeScript code
- Cleaned up orphaned dist/dev directory that contained stale build artifacts
- The remaining build step after version detection handles all actual build
  requirements

This simplifies the CI pipeline and removes ~30 seconds of unnecessary build
time on each main branch push.
Copilot AI review requested due to automatic review settings September 18, 2025 01:12
@sapientpants sapientpants self-assigned this Sep 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unnecessary build step from the GitHub Actions main workflow that was running before version management. The removed build was originally intended to compile a custom changelog generator, but the actual implementation uses an npm package instead.

  • Removes redundant "Build for changeset" step from the CI pipeline
  • Eliminates misleading comments about custom TypeScript changelog generation
  • Streamlines workflow execution by removing unnecessary operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@deepsource-io
Copy link

deepsource-io bot commented Sep 18, 2025

Here's the code health analysis summary for commits 797e864..921989c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateJavascript
Branch Coverage88%88%
Composite Coverage89.6%89.6%
Line Coverage90%90%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@sapientpants sapientpants merged commit 765ad1f into main Sep 18, 2025
10 checks passed
@sapientpants sapientpants deleted the chore/remove-redundant-build-step branch September 18, 2025 01:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant