Open
Conversation
|
It's lovely! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so i added a swinging lamp, if only because I wanted to learn how to do the animation.
Anyway, the most annoying thing was when i decided to move it between the two trains and doing so wrecked the vertical positioning of the other divs, i'd suggest changing from position:relative to position:absolute, but i'm not sure about any other side effects.
I was also confused by the ease option on the animation, but settled with ease-in-out as it seems to give the closest to simple pendulumn motion...
anyway, just thought you'd like to see :)