Open
Conversation
Since JDK9, JAXB is deprecated and was entirely removed in JDK11. This change adds version 2.3.0 (used in JDK9) as an explicit dependency to instruct maven to include it in the generated archive.
|
Dear maintainers (@sarahtattersall and @sjdayday ... right?) it would be great if this PR was merged! It is very limited in scope but allows for PIPE to be useful beyond Java 8. Thanks! |
|
Wait... this PR is not enough, it only adds the JAXB-API, but no implementation. Saving a petri net in PIPE-gui still fails, complaining about the missing JAXB implementation: Adding the jaxb implementation dependency fixes this. I'll prepare a PR to that effect. |
In order to run on Java 9+, this dependency needs to be stated explicitly. If only the API is added, compiling works, but saving a petri net in PIPE-gui does not. Adding the implementation fixes the latter, too.
|
Should not be merged before obgm#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since JDK9, JAXB is deprecated and was entirely removed in JDK11.
This change adds version 2.3.0 (used in JDK9) as an explicit dependency to instruct maven to include it in the generated archive.