fix: onRatingUpdate called with wrong state#104
Open
asci-00 wants to merge 1 commit intosarbagyastha:mainfrom
Open
fix: onRatingUpdate called with wrong state#104asci-00 wants to merge 1 commit intosarbagyastha:mainfrom
asci-00 wants to merge 1 commit intosarbagyastha:mainfrom
Conversation
Author
|
@sarbagyastha Could you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for providing flutter_rating_bar.
There is something I would like to contribute while using this, so I would like to request a PR.
Problem
iconRatingis changed,onRatingUpdateis not called immediately, so if the_ratingstate changes quickly, theiconRatingvalue referenced by_onDragUpdate/_onDragEndmay not be up to date.Describe your changes
ratingOffsetinto commonly used states rather than individual methods. (_ratingOffset)IconRatingdid not seem to need to be dependent on the index, so I modified it to be agetterbased on the_ratingvalue independently. It seems to be working well in my code. Could you please give me some feedback on this?iconRatingcalculation method. This part may also be different from what you intended, so please give me feedback and I will correct it.Issue ticket number and link
#76