handle no value in xml w/ jasquat

Author: burnettk

SpiffWorkflow/spiff/parser/task_spec.py

@@ -84,7 +84,7 @@ def _parse_task_metadata_values(cls, node):
         metadata_value_nodes = cls._node_children_by_tag_name(node, 'taskMetadataValue')
         metadata_values = {}
         for metadata_node in metadata_value_nodes:
-            metadata_values[metadata_node.attrib['name']] = metadata_node.attrib['value']
+            metadata_values[metadata_node.attrib['name']] = metadata_node.attrib.get('value', None)
         return metadata_values
 
     @staticmethod

tests/SpiffWorkflow/spiff/HumanTaskMetadataTest.py

@@ -25,3 +25,7 @@ def testTaskMetadataValues(self):
         # Check that the metadata values are correctly parsed
         self.assertEqual(task_metadata_values['dynamic_key'], 'my_var')
         self.assertEqual(task_metadata_values['static_key'], "'static_value'")
+
+        # Check that metadata values without a value attribute are set to None
+        self.assertIsNone(task_metadata_values['key_with_no_value_property_in_xml'],
+                         "Metadata value without value attribute should be None")

tests/SpiffWorkflow/spiff/data/human_task_metadata.bpmn

@@ -20,6 +20,7 @@
         <spiffworkflow:taskMetadataValues>
           <spiffworkflow:taskMetadataValue name="dynamic_key" value="my_var" />
           <spiffworkflow:taskMetadataValue name="static_key" value="'static_value'" />
+          <spiffworkflow:taskMetadataValue name="key_with_no_value_property_in_xml" />
         </spiffworkflow:taskMetadataValues>
       </bpmn:extensionElements>
       <bpmn:incoming>Flow_0b04rbg</bpmn:incoming>