Skip to content

Commit 0c4ea16

Browse files
committed
request PRR approval
1 parent 151a42a commit 0c4ea16

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kep-number: 2129
2+
stable:
3+
approver: "@johnbelamaric"

keps/sig-node/2129-remove-cadvisor-json-metrics/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,11 @@ For machine metrics: Use the prometheus node exporter.
8989
* Pros: Community-supported and widely used machine-level monitoring tool. Easy-to-use configuration to enable/disable metrics.
9090
* Cons: Metrics are in a different format, and may not have the same set of information
9191

92+
For most metrics, run a prometheus server, and collect metrics from the /metrics/cadvisor endpoint.
93+
If you want to be able to access metrics in JSON format, you can use the [Prometheus server's HTTP API](https://prometheus.io/docs/prometheus/latest/querying/api/).
94+
* Pros: Similar metrics in JSON format
95+
* Cons: The JSON structure of metrics is different, and it requires running a prometheus server.
96+
9297
## Design Details
9398

9499
Remove the `--enable-cadvisor-json-endpoints` flag and the kubelet stops serving on the paths listed in the Goals section.

keps/sig-node/2129-remove-cadvisor-json-metrics/kep.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ approvers:
1313
- "derekwaynecarr"
1414
- "dawnchen"
1515
prr-approvers:
16+
- "@johnbelamaric"
1617
replaces: []
1718

1819
# The target maturity stage in the current dev cycle for this KEP.

0 commit comments

Comments
 (0)