Skip to content

Commit 11053a2

Browse files
committed
update test plan
Signed-off-by: Peter Hunt <[email protected]>
1 parent e85591e commit 11053a2

File tree

1 file changed

+68
-0
lines changed
  • keps/sig-node/2371-cri-pod-container-stats

1 file changed

+68
-0
lines changed

keps/sig-node/2371-cri-pod-container-stats/README.md

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
- [CRI implementations](#cri-implementations)
2929
- [cAdvisor](#cadvisor-1)
3030
- [Test Plan](#test-plan)
31+
- [Prerequisite testing updates](#prerequisite-testing-updates)
32+
- [Unit tests](#unit-tests)
33+
- [Integration tests](#integration-tests)
34+
- [e2e tests](#e2e-tests)
3135
- [Graduation Criteria](#graduation-criteria)
3236
- [Alpha implementation](#alpha-implementation)
3337
- [Alpha -&gt; Beta Graduation](#alpha---beta-graduation)
@@ -529,10 +533,74 @@ As a requirement for the Beta stage, cAdvisor must support optionally collecting
529533

530534
### Test Plan
531535

536+
<!--
537+
**Note:** *Not required until targeted at a release.*
538+
The goal is to ensure that we don't accept enhancements with inadequate testing.
539+
All code is expected to have adequate tests (eventually with coverage
540+
expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
541+
when drafting this test plan.
542+
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
543+
-->
544+
545+
[x] I/we understand the owners of the involved components may require updates to
546+
existing tests to make this code solid enough prior to committing the changes necessary
547+
to implement this enhancement.
548+
549+
##### Prerequisite testing updates
550+
551+
<!--
552+
Based on reviewers feedback describe what additional tests need to be added prior
553+
implementing this enhancement to ensure the enhancements have also solid foundations.
554+
-->
555+
556+
##### Unit tests
557+
558+
<!--
559+
In principle every added code should have complete unit test coverage, so providing
560+
the exact set of tests will not bring additional value.
561+
However, if complete unit test coverage is not possible, explain the reason of it
562+
together with explanation why this is acceptable.
563+
-->
564+
565+
<!--
566+
Additionally, for Alpha try to enumerate the core package you will be touching
567+
to implement this enhancement and provide the current unit coverage for those
568+
in the form of:
569+
- <package>: <date> - <current test coverage>
570+
The data can be easily read from:
571+
https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
572+
This can inform certain test coverage improvements that we want to do before
573+
extending the production code to implement this enhancement.
574+
-->
575+
576+
- `pkg/kubelet/server/stats`: 06-15-2022 - 74.9
577+
578+
##### Integration tests
579+
580+
<!--
581+
This question should be filled when targeting a release.
582+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
583+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
584+
https://storage.googleapis.com/k8s-triage/index.html
585+
-->
586+
532587
- Internally in the Kubelet, there should be integration tests verifying that information gotten from the two sources is not too different.
533588
- Each CRI implementation should do regression testing on performance to make sure the gathering of these stats is reasonably efficient.
534589
- Any identified external user of either of these endpoints (prometheus, metrics-server) should be tested to make sure they're not broken by API changes.
535590

591+
592+
##### e2e tests
593+
594+
<!--
595+
This question should be filled when targeting a release.
596+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
597+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
598+
https://storage.googleapis.com/k8s-triage/index.html
599+
We expect no non-infra related flakes in the last month as a GA graduation criteria.
600+
-->
601+
602+
- A test using the CRI stats feature gate with enabled CRI implementations should be used with cri_stats_provider to ensure the stats reported are conformant.
603+
536604
### Graduation Criteria
537605
#### Alpha implementation
538606

0 commit comments

Comments
 (0)