Skip to content

Commit 2277299

Browse files
committed
Apply feedback
1 parent 529c9d6 commit 2277299

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

keps/sig-api-machinery/4355-coordinated-leader-election/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ To respect the [Kubernetes skew policy](https://kubernetes.io/releases/version-s
189189

190190
But a node-by-node upgrade or rollback does not achieve this today.
191191

192-
- For upgrade, there is about a 25% chance of a new version of the controller
192+
- For 3 node control plane upgrade, there is about a 25% chance of a new version of the controller
193193
running while old versions of the apiserver are active, resulting in a skew
194194
violation. (Consider case where the 2nd node upgraded has the lease)
195195
- For rollback, it is almost a certainty that skew will be violated.
@@ -236,12 +236,12 @@ kind: Lease
236236
metadata:
237237
annotations:
238238
coordination.k8s.io/binary-version: "1.29"
239-
coordination.k8s.io/can-lead-leases: kube-system/sample-controller
239+
coordination.k8s.io/can-lead-leases: kube-system/some-custom-controller
240240
coordination.k8s.io/compatibility-version: "1.29"
241-
name: sample-controller-0001A
241+
name: some-custom-controller-0001A
242242
namespace: kube-system
243243
spec:
244-
holderIdentity: sample-controller-0001A
244+
holderIdentity: some-custom-controller-0001A
245245
leaseDurationSeconds: 10
246246
renewTime: "2023-12-05T02:33:08.685777Z"
247247
```
@@ -284,7 +284,7 @@ kind: Lease
284284
metadata:
285285
annotations:
286286
coordination.k8s.io/elected-by: coordinated-election-controller
287-
name: sample-controller
287+
name: some-custom-controller
288288
namespace: kube-system
289289
spec:
290290
holderIdentity: controller-a

keps/sig-api-machinery/4355-coordinated-leader-election/kep.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ authors:
44
- "@jpbetz"
55
owning-sig: sig-api-machinery
66
participating-sigs:
7+
- sig-cluster-lifecycle
78
status: provisional
89
creation-date: 2023-14-05
910
reviewers:

0 commit comments

Comments
 (0)