Skip to content

Commit 25089fb

Browse files
committed
sidecar: Remove type Standard
This was requested by Tim some months ago: kubernetes/kubernetes#79649 (comment) I didn't get that it should be removed, I just thought it should not be set by default. But Joseph Irving just clarified that for me: kubernetes#1980 (comment) Signed-off-by: Rodrigo Campos <[email protected]>
1 parent 4409f9d commit 25089fb

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

keps/sig-node/0753-sidecarcontainers.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ This proposal doesn't aim to:
308308

309309
## Proposal
310310

311-
Create a way to define containers as sidecars, this will be an additional field to the `container.lifecycle` spec: `Type` which can be either `Standard` (default) or `Sidecar`.
311+
Create a way to define containers as sidecars, this will be an additional field to the `container.lifecycle` spec: `Type` can be either nil (default behavior is used) or `Sidecar`. IOW, if the field is not present default behavior is used and the container is not a sidecar container.
312312

313313
e.g:
314314
```yaml
@@ -463,22 +463,19 @@ New field `Type` will be added to the lifecycle struct:
463463

464464
```go
465465
type Lifecycle struct {
466-
// Type
467-
// One of Standard, Sidecar.
468-
// Defaults to Standard
466+
// Type specifies the container type.
467+
// It can be sidecar or, if not present, default behavior is used
469468
// +optional
470469
Type LifecycleType `json:"type,omitempty" protobuf:"bytes,3,opt,name=type,casttype=LifecycleType"`
471470
}
472471
```
473-
New type `LifecycleType` will be added with two constants:
472+
New type `LifecycleType` will be added with one constant:
474473
```go
475474
// LifecycleType describes the lifecycle behaviour of the container
476475
type LifecycleType string
477476

478477
const (
479-
// LifecycleTypeStandard is the default container lifecycle behaviour
480-
LifecycleTypeStandard LifecycleType = "Standard"
481-
// LifecycleTypeSidecar means that the container will start up before standard containers and be terminated after
478+
// LifecycleTypeSidecar means that the container will start up before non-sidecar containers and be terminated after
482479
LifecycleTypeSidecar LifecycleType = "Sidecar"
483480
)
484481
```

0 commit comments

Comments
 (0)