Skip to content

Commit 572ad86

Browse files
authored
Mark KEP 1659 as "implemented" (kubernetes#2120)
* Mark KEP 1659 implementable * Implemented 1659
1 parent 9ea79c5 commit 572ad86

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

keps/sig-architecture/1659-standard-topology-labels/README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ To get started with this template:
4343
- [Design Details](#design-details)
4444
- [Reserve a label prefix](#reserve-a-label-prefix)
4545
- [Defining the meaning of existing labels](#defining-the-meaning-of-existing-labels)
46+
- [Redefining kubernetes.io/hostname](#redefining-kubernetesiohostname)
4647
- [Defining a third key (or not)](#defining-a-third-key-or-not)
4748
- [Followup work (or optionally part of this)](#followup-work-or-optionally-part-of-this)
4849
- [Test Plan](#test-plan)
@@ -190,9 +191,11 @@ This will also define that, while labels are generally mutable, the topology
190191
labels should be assumed immutable and that any changes to them may be ignored
191192
by downstream consumers of topology.
192193

193-
<<[UNRESOLVED]>>
194-
Should we also try to standardize "kubernetes.io/hostname" as "topology.kubernetes.io/node" ?
195-
<<[/UNRESOLVED]>>
194+
### Redefining kubernetes.io/hostname
195+
196+
The widely-known label "kubernetes.io/hostname" might be better as
197+
"topology.kubernetes.io/node", but that change is considered out of scope for
198+
this KEP. We may or may not choose to tackle it at a later time.
196199

197200
### Defining a third key (or not)
198201

keps/sig-architecture/1659-standard-topology-labels/kep.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ participating-sigs:
77
- sig-cloud-provider
88
- sig-network
99
- sig-scheduling
10-
status: provisional
10+
status: implemented
1111
creation-date: 2020-03-31
1212
reviewers:
1313
- "@andrewsykim"
@@ -19,11 +19,6 @@ replaces: []
1919
prr-approvers:
2020
- "@johnbelamaric"
2121
stage: stable
22-
latest-milestone: "v1.19"
23-
milestone:
24-
alpha: "v1.19"
25-
beta: "v1.19"
26-
stable: "v1.19"
2722
feature-gates: []
2823
disable-supported: false
2924
metrics: []

0 commit comments

Comments
 (0)