Skip to content

Commit 62505f6

Browse files
authored
Merge pull request kubernetes#3358 from humblec/rbd-migration
KEP-2923: update test plan and milestone for RBD CSI migration
2 parents 4030bd8 + 7f908cc commit 62505f6

File tree

2 files changed

+38
-3
lines changed

2 files changed

+38
-3
lines changed

keps/sig-storage/2923-csi-migration-ceph-rbd/README.md

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@
55
<!-- toc -->
66
- [Summary](#summary)
77
- [New Feature Gates](#new-feature-gates)
8+
- [Design Details](#design-details)
9+
- [Test Plan](#test-plan)
10+
- [Prerequisite testing updates](#prerequisite-testing-updates)
11+
- [Unit tests](#unit-tests)
12+
- [Integration tests](#integration-tests)
13+
- [e2e tests](#e2e-tests)
814
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
915
- [Implementation History](#implementation-history)
1016
<!-- /toc -->
@@ -35,6 +41,35 @@ used as described in its parent KEP. For all other contents, please refer to the
3541
on kubelet and treat Ceph RBD CSI migration as already complete. And directly redirect traffic to CSI
3642
driver for all rbd related operations.
3743

44+
## Design Details
45+
46+
### Test Plan
47+
48+
[X] I/we understand the owners of the involved components may require updates to
49+
existing tests to make this code solid enough prior to committing the changes necessary
50+
to implement this enhancement.
51+
52+
##### Prerequisite testing updates
53+
54+
No additional tests are needed, rather the issue is orchestrating CSI driver
55+
deployment for prow jobs. This means that it is not possible to run any test for
56+
RBD in k/k repository.
57+
58+
##### Unit tests
59+
60+
The unit tests for RBD translation lib available [here](https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/rbd_test.go)
61+
will be validated.
62+
63+
##### Integration tests
64+
65+
N/A
66+
67+
##### e2e tests
68+
69+
Support for tests after RBD migration will be covered by the subjected
70+
RBD CSI driver which is available [here](https://github.com/ceph/ceph-csi/blob/devel/e2e/rbd.go#L426).
71+
Addition to above, in-tree RBD driver tests available [here](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/in_tree.go#L488)
72+
also cover the e2e part of this feature.
3873

3974
## Production Readiness Review Questionnaire
4075

@@ -50,6 +85,6 @@ Major milestones for Ceph RBD in-tree plugin CSI migration:
5085

5186
- 1.23
5287
- Ceph RBD CSI migration to Alpha
53-
- 1.24
88+
- 1.25
5489
- Ceph RBD CSI migration to Beta, off by default
5590

keps/sig-storage/2923-csi-migration-ceph-rbd/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@ stage: beta
2727
# The most recent milestone for which work toward delivery of this KEP has been
2828
# done. This can be the current (upcoming) milestone, if it is being actively
2929
# worked on.
30-
latest-milestone: "v1.24"
30+
latest-milestone: "v1.25"
3131

3232
# The milestone at which this feature was, or is targeted to be, at each stage.
3333
milestone:
3434
alpha: "v1.23"
35-
beta: "v1.24"
35+
beta: "v1.25"
3636

3737
# The following PRR answers are required at alpha release
3838
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)