Skip to content

Commit 69769b6

Browse files
authored
Merge pull request kubernetes#2459 from serathius/beta-structured-logging
Scope structured logging Beta
2 parents 4bd1907 + f28e6f6 commit 69769b6

File tree

1 file changed

+12
-15
lines changed
  • keps/sig-instrumentation/1602-structured-logging

1 file changed

+12
-15
lines changed

keps/sig-instrumentation/1602-structured-logging/README.md

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -373,28 +373,25 @@ Klog interface was selected as it is already supported by klog.v2 with `SetLogge
373373

374374
Introduce structured logging and JSON format:
375375
* Most important logs are migrated to structured methods.
376-
* Flag for selecting logging format is implemented
377-
* JSON format is implemented
376+
* Flag for selecting logging format is implemented.
377+
* JSON format is implemented.
378378

379379
#### Beta
380380

381-
Adding guarding against regression and update user guideline:
382-
* Static analysis protects important log lines from reverting to string formating
383-
* [Kubernetes Logging convention](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md) document is updated
384-
385-
Components in scope:
386-
* Kubelet
387-
388-
All other component migrations will be best effort.
381+
Bring feature quality up to and prevent regression during ongoing migration:
382+
* Directories can be marked as migrated, preventing regression via verify script in `hack`.
383+
* [Kubernetes Logging documentation](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md) is updated for structured logging.
384+
* Json format should support same set of feature flags as text format, minus those we will decide to deprecte.
385+
* Structured logging interface design is verify by migrating one whole component (Kubelet) to structured logging. All other component migrations will be best effort.
389386

390387
#### GA
391388

392389
Logging formats become an API:
393-
* Feedback about logging methods and log formats is collected and addressed
394-
* Format string methods are deprecated
395-
* Static analysis protects against creating new string format calls
396-
* Logging output formats fall under [Kubernetes deprecation policy](https://kubernetes.io/docs/reference/using-api/deprecation-policy/)
397-
* All remaining components must be migrated
390+
* Feedback about logging methods and log formats is collected and addressed.
391+
* Format string methods are deprecated.
392+
* Static analysis protects against creating new string format calls.
393+
* Logging output formats fall under [Kubernetes deprecation policy](https://kubernetes.io/docs/reference/using-api/deprecation-policy/).
394+
* All remaining components must be migrated.
398395

399396
### Performance
400397

0 commit comments

Comments
 (0)