-
Notifications
You must be signed in to change notification settings - Fork 366
Enable AOT build for windows-arm64 #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8d12d3d
Enable AOT build for windows-arm64
ntkme 9d87791
Refactor to use composite action to initialize
ntkme b2344d3
Add a comment
ntkme 2f85466
Try powershell instead of pwsh
ntkme 2d14ed6
Use actions/checkout instead of git command
ntkme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,20 +17,55 @@ runs: | |
with: | ||
node-version: "${{ inputs.node-version }}" | ||
|
||
# See: https://github.com/dart-lang/sdk/issues/52266 | ||
- run: Invoke-WebRequest https://pub.dev | ||
if: runner.os == 'Windows' | ||
shell: powershell | ||
|
||
# See: https://github.com/orgs/community/discussions/131594 | ||
# The composite action requires an explict shell, but bash is not available on windows-arm64 runner. | ||
# For the following commands conditionally use bash or powershell based on the runner.os: | ||
- run: dart pub get | ||
if: runner.os != 'Windows' | ||
shell: bash | ||
|
||
- run: dart pub get | ||
if: runner.os == 'Windows' | ||
shell: powershell | ||
|
||
- run: npm install | ||
if: runner.os != 'Windows' | ||
shell: bash | ||
|
||
- run: npm install | ||
if: runner.os == 'Windows' | ||
shell: powershell | ||
|
||
- uses: bufbuild/[email protected] | ||
with: {github_token: "${{ inputs.github-token }}"} | ||
|
||
# This composite action requires bash, but bash is not available on windows-arm64 runner. | ||
# Avoid running this composite action on non-PR, so that we can release on windows-arm64. | ||
- name: Check out the language repo | ||
if: github.event_name == 'pull_request' | ||
ntkme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uses: sass/clone-linked-repo@v1 | ||
with: {repo: sass/sass, path: build/language} | ||
|
||
# Git is not pre-installed on windows-arm64 runner, however actions/checkout support | ||
# downloading repo via GitHub API. | ||
- name: Check out the language repo | ||
if: github.event_name != 'pull_request' | ||
uses: actions/checkout@v4 | ||
with: {repository: sass/sass, path: build/language} | ||
|
||
- name: Generate Dart from protobuf | ||
if: runner.os != 'Windows' | ||
run: dart run grinder protobuf | ||
env: {UPDATE_SASS_SASS_REPO: false} | ||
shell: bash | ||
|
||
- name: Generate Dart from protobuf | ||
if: runner.os == 'Windows' | ||
run: dart run grinder protobuf | ||
env: {UPDATE_SASS_SASS_REPO: false} | ||
shell: powershell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,29 +19,13 @@ jobs: | |
- arch: ia32 | ||
runner: windows-latest | ||
- arch: arm64 | ||
# This should be windows-arm64, but it's broken by several issues: | ||
# https://github.com/orgs/community/discussions/131594 | ||
# https://github.com/orgs/community/discussions/131754 | ||
runner: windows-latest | ||
runner: windows-arm64 | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
# See: https://github.com/orgs/community/discussions/131594 | ||
# The composite action requires bash which is not available on windows-arm64 runner. | ||
# - uses: ./.github/util/initialize | ||
# with: {github-token: "${{ github.token }}"} | ||
|
||
- uses: dart-lang/setup-dart@v1 | ||
|
||
- uses: bufbuild/[email protected] | ||
with: {github_token: "${{ github.token }}"} | ||
|
||
- name: Install Dependencies | ||
run: dart pub get --verbose | ||
|
||
- name: Compile Protobuf | ||
run: dart run grinder protobuf | ||
- uses: ./.github/util/initialize | ||
with: {github-token: "${{ github.token }}"} | ||
|
||
- name: Build | ||
run: dart run grinder pkg-standalone-windows-${{ matrix.arch }} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.