Skip to content

Fix CI by pinning postcss version to 8.5.5 and disable app armor for browser tests #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Fix CI by pinning postcss version to 8.5.5 and disable app armor for browser tests #2606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4625579
Pin postcss version to 8.5.5
Goodwine Jul 8, 2025
ba3e009
disable app armor for browser tests
Goodwine Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,13 +309,14 @@ jobs:

- run: dart run grinder pkg-npm-dev
env: {UPDATE_SASS_SASS_REPO: false}
- run: sudo chmod 4755 /opt/google/chrome/chrome-sandbox
# See https://github.com/puppeteer/puppeteer/issues/12818
# Ubuntu 23+ doesn't like running puppeteer without disabling AppArmor.
- name: Disable AppArmor
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
- name: Run tests
run: dart run test -p chrome -j 2
env:
CHROME_EXECUTABLE: chrome
# See https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md#option-3_the-safest-way
CHROME_DEVEL_SANDBOX: /opt/google/chrome/chrome-sandbox

sass_parser_tests:
name: "sass-parser Tests | Dart ${{ matrix.dart_channel }} | Node ${{ matrix.node-version }}"
Expand All @@ -328,7 +329,7 @@ jobs:
node-version: ['lts/*']
include:
# Test older LTS versions
#
#
# TODO: Test on lts/-2 and lts/-3 once they support
# `structuredClone()` (that is, once they're v18 or later).
- os: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion pkg/sass-parser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"test": "jest"
},
"dependencies": {
"postcss": ">=8.4.41 <8.6.0",
"postcss": "8.5.5",
"sass": "file:../../build/npm"
},
"devDependencies": {
Expand Down