This repository was archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support up to Electron 8 #2862
Closed
Closed
Support up to Electron 8 #2862
Changes from 12 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
f57f4b4
Support upto Electron 8 (Windows ONLY)
glenn2223 9c5aeb6
Docs to expand on Electron Support
glenn2223 7f5b6bf
Update Electron-Support.md
glenn2223 90e697d
Update Electron-Support.md
glenn2223 e6b1a43
Reverted isSupportedEnvironment
glenn2223 0661d3b
Create electron-win.yml
glenn2223 92b7ef0
Delete Electron-Support.md
glenn2223 1760a4c
Removed bindings
glenn2223 ed1c343
Merge branch 'master' of https://github.com/glenn2223/node-sass
glenn2223 97a903b
Update electron-win.yml
glenn2223 2bc2261
Updated node-gyp to 6.1.0
glenn2223 5fe05fa
Renamed artifacts to almost match
glenn2223 80a5070
Workflow changes
glenn2223 7368214
Update electron-linux.yml
glenn2223 f3aaea6
Workflow updates
glenn2223 18687aa
Workflow updates
glenn2223 499e066
Workflow updates
glenn2223 9642e7b
Fixes
glenn2223 d95fc8a
Update electron-linux.yml
glenn2223 9d01660
Update electron-linux.yml
glenn2223 69ddf4c
Update electron-linux.yml
glenn2223 2cc27f0
Update electron-linux.yml
glenn2223 480890d
Update electron-linux.yml
glenn2223 72ed801
Update electron-linux.yml
glenn2223 138d277
Dropped x32 from linux workflow
glenn2223 165f68a
Reverted to electron rebuild
glenn2223 2eb370e
Merge branch 'master' of https://github.com/glenn2223/node-sass
glenn2223 ed333ad
Update electron-win.yml
glenn2223 4da3d46
Update workflows
glenn2223 17cfbc0
Workflow updates
glenn2223 a1db6da
Workflow updates
glenn2223 818b048
Removed unrequired dependancy
glenn2223 9faff00
Update electron-win.yml
glenn2223 23927c8
Linux test
glenn2223 7c35440
Update electron-linux.yml
glenn2223 f1bdcea
Final workflow update
glenn2223 78048c9
Windows workflow correction
glenn2223 2e93037
Update electron-win.yml
glenn2223 c65aa3c
Small tweaks to workers
glenn2223 403a152
Workflow update
glenn2223 a7543a1
Windows workflow update
glenn2223 96f12b6
Update electron-win.yml
glenn2223 3e7526a
Update electron-win.yml
glenn2223 45801f7
Final windows workflow change
glenn2223 99a6b2f
Final windows workflow change
glenn2223 0ec38a7
Test 8
glenn2223 d8bda5a
Reverted windows workflow
glenn2223 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
name: Electron Rebuild CI - Windows (x32 & x64) | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: windows-latest | ||
|
||
strategy: | ||
matrix: | ||
electron: | ||
- 5.0.0 #70 | ||
- 6.0.0 #73 | ||
- 7.0.0 #75 | ||
- 8.0.0 #76 | ||
arch: | ||
- ia32 | ||
- x64 | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js | ||
uses: actions/setup-node@v1 | ||
with: | ||
os: ${{ matrix.os }} | ||
- name: Node Ver (For debugging) | ||
run: node -v | ||
- name: Install packages | ||
run: npm install --unsafe-perm | ||
- name: Run on ${{ matrix.os }} - Electron v${{ matrix.electron }} | ||
run: node ".\node_modules\node-gyp\bin\node-gyp.js" rebuild --target=${{ matrix.electron }} --arch=${{ matrix.arch }} --dist-url=https://electronjs.org/headers | ||
- uses: actions/upload-artifact@v1 | ||
with: | ||
name: win32_${{ matrix.arch }}_${{ matrix.electron }}.node | ||
path: build/release/binding.node | ||
- uses: actions/upload-artifact@v1 | ||
with: | ||
name: win32_${{ matrix.arch }}_${{ matrix.electron }}.pdb | ||
path: build/release/binding.pdb | ||
- run: npm test | ||
env: | ||
CI: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.