docs: (PSKD-1500) update CONTRIBUTING.md with new expectations#626
Merged
docs: (PSKD-1500) update CONTRIBUTING.md with new expectations#626
Conversation
Signed-off-by: Ian Dominno <Ian.Dominno@sas.com>
github-actions
bot
added
the
documentation
saschjmil
reviewed
Apr 18, 2025
Contributor
saschjmil
left a comment
saschjmil
left a comment
There was a problem hiding this comment.
Can you update the Code Reviews section to match the Azure one? https://github.com/sassoftware/viya4-iac-azure/blob/staging/CONTRIBUTING.md#code-reviews
Signed-off-by: Ian Dominno <Ian.Dominno@sas.com>
saschjmil
approved these changes
Apr 18, 2025
PhanikumarThodupunoori
approved these changes
Apr 18, 2025
saschjmil
pushed a commit
that referenced
this pull request
May 1, 2025
* docs: (PSKD-1500) update CONTRIBUTING.md with new expectations Signed-off-by: Ian Dominno <Ian.Dominno@sas.com> * docs: (PSKD-1500) update CONTRIBUTING.md with new expectations Signed-off-by: Ian Dominno <Ian.Dominno@sas.com> --------- Signed-off-by: Ian Dominno <Ian.Dominno@sas.com>
saschjmil
pushed a commit
that referenced
this pull request
May 7, 2025
* docs: (PSKD-1500) update CONTRIBUTING.md with new expectations Signed-off-by: Ian Dominno <Ian.Dominno@sas.com> * docs: (PSKD-1500) update CONTRIBUTING.md with new expectations Signed-off-by: Ian Dominno <Ian.Dominno@sas.com> --------- Signed-off-by: Ian Dominno <Ian.Dominno@sas.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the CONTRIBUTING.md file with new expectations which include: