Skip to content

feat!: replace nfs-subdir-external-provisioner with csi-driver-nfs#637

Merged
saschjmil merged 13 commits intomainfrom
pr-pskd-807
May 14, 2025
Merged

feat!: replace nfs-subdir-external-provisioner with csi-driver-nfs#637
saschjmil merged 13 commits intomainfrom
pr-pskd-807

Conversation

@saschjmil
Copy link
Contributor

@saschjmil saschjmil commented May 13, 2025

Breaking Change

Replace the nfs-subdir-external-provisioner with the nfs.cs.k8s.io csi-driver-nfs. The nfs-subdir-external-provisioner is outdated, it is unmaintained and has known vulnerabilities.

Since this renames existing configuration variables, I am marking it as a breaking change.

Variable changes

Previous Name New Name New Default
NFS_CLIENT_NAMESPACE CSI_DRIVER_NFS_NAMESPACE kube-system
NFS_CLIENT_CHART_URL CSI_DRIVER_NFS_CHART_URL https://raw.githubusercontent.com/kubernetes-csi/csi-driver-nfs/master/charts
NFS_CLIENT_CHART_NAME CSI_DRIVER_NFS_CHART_NAME csi-driver-nfs
NFS_CLIENT_CHART_VERSION CSI_DRIVER_NFS_CHART_VERSION 4.11.0
NFS_CLIENT_CONFIG CSI_DRIVER_NFS_CONFIG See here for the full list of changes
PG_NFS_CLIENT_NAMESPACE CSI_DRIVER_NFS_PG_NAMESPACE nfs-client
PG_NFS_CLIENT_CHART_URL CSI_DRIVER_NFS_PG_CHART_URL https://raw.githubusercontent.com/kubernetes-csi/csi-driver-nfs/master/charts
PG_NFS_CLIENT_CHART_NAME CSI_DRIVER_NFS_PG_CHART_NAME csi-driver-nfs
PG_NFS_CLIENT_CHART_VERSION CSI_DRIVER_NFS_PG_CHART_VERSION 4.11.0
PG_NFS_CLIENT_CONFIG CSI_DRIVER_NFS_PG_CONFIG See here for the full list of changes

Tests

Scenario DaC use method Provider Cadence Storage Type Postgres
1 Docker OOTB AWS stable:2025.03 NFS VM Crunchy
2 Docker OOTB AWS stable:2025.04 EFS Crunchy
3 Docker OOTB AWS stable:2025.04 ONTAP Crunchy
4 Docker OOTB AWS stable:2025.04 NFS VM External Postgres Database Server
- - - - - -
5 Docker OOTB Azure stable:2025.04 NFS VM Crunchy
6 Docker OOTB Azure stable:2025.04 NetApp Crunchy
7 Docker OOTB Azure stable:2025.04 NFS VM External Postgres Database Server
- - - - - -
8 Docker OOTB GCP fast:2020 NFS VM Crunchy
9 Docker OOTB GCP stable:2025.04 Google Filestore Crunchy
10 Docker OOTB GCP stable:2025.04 NetApp Crunchy
11 Docker OOTB GCP stable:2025.04 NFS VM External Postgres Database Server

iadomi and others added 12 commits May 6, 2025 20:16
* docs: (PSKD-1500) update CONTRIBUTING.md with new expectations

Signed-off-by: Ian Dominno <Ian.Dominno@sas.com>

* docs: (PSKD-1500) update CONTRIBUTING.md with new expectations

Signed-off-by: Ian Dominno <Ian.Dominno@sas.com>

---------

Signed-off-by: Ian Dominno <Ian.Dominno@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
Signed-off-by: chjmil <christopher.miller@sas.com>
@github-actions github-actions bot added enhancement New feature or request breaking change labels May 13, 2025
@saschjmil saschjmil changed the title feat!: replace nfs-subdir-external-provisioner with nfs.csi.k8s.io feat!: replace nfs-subdir-external-provisioner with csi-driver-nfs May 14, 2025
@saschjmil saschjmil marked this pull request as ready for review May 14, 2025 13:30
Signed-off-by: chjmil <christopher.miller@sas.com>
@saschjmil saschjmil merged commit 80a98bf into main May 14, 2025
5 checks passed
@saschjmil saschjmil deleted the pr-pskd-807 branch May 14, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: (IAC-1104) Replace nfs-subdir-external-provisioner with nfs.csi.k8s.io

4 participants