fix: Expand categories supported by inject-sas-bases-overlays feature#640
Merged
saschjmil merged 2 commits intosassoftware:mainfrom May 22, 2025
Merged
fix: Expand categories supported by inject-sas-bases-overlays feature#640saschjmil merged 2 commits intosassoftware:mainfrom
saschjmil merged 2 commits intosassoftware:mainfrom
Conversation
…o support components refs in inject-sas-bases-overlays file, instead of only sas-bases/overlays (issue 634) Signed-off-by: Jeff Owens <jeff.owens@sas.com>
This was referenced May 20, 2025
ephesused
requested changes
May 21, 2025
Contributor
ephesused
left a comment
ephesused
left a comment
There was a problem hiding this comment.
This looks good to me; thanks!
I have just one request, to adjust the corresponding documentation. Will you please edit the top-level README.md, at this line, changing:
Base kustomization.yaml additions from sas-bases/overlays
to:
Base kustomization.yaml additions from sas-bases/
Thanks again.
Signed-off-by: Jeff Owens <jeff.owens@sas.com>
ephesused
approved these changes
May 21, 2025
Contributor
ephesused
left a comment
ephesused
left a comment
There was a problem hiding this comment.
LGTM
On our end we're looking into what's happening with the failed workflow.
saschjmil
approved these changes
May 22, 2025
Contributor
saschjmil
left a comment
saschjmil
left a comment
There was a problem hiding this comment.
Looks good to me. I believe the failing workflow is due to this PR coming from a fork. We will need to look into it, but it shouldn't stop this from being merged.
saschjmil
added
enhancement
Contributor
|
Changing this from a bug to an enhancement. It has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simply narrows the scope of the
requiredPrefixesvar fromsas-bases/overlaysto justsas-bases, in order to support more categories of sas-bases refs for injection. The enum already covers the possible keys.