Skip to content

docs: line by line documentation of DaC#644

Merged
saschjmil merged 12 commits intosassoftware:mainfrom
cebaldauff:adios-documentation
Jun 10, 2025
Merged

docs: line by line documentation of DaC#644
saschjmil merged 12 commits intosassoftware:mainfrom
cebaldauff:adios-documentation

Conversation

@cebaldauff
Copy link
Contributor

No description provided.

@cebaldauff cebaldauff marked this pull request as draft June 2, 2025 22:37
@cebaldauff cebaldauff marked this pull request as ready for review June 5, 2025 20:33
@cebaldauff cebaldauff force-pushed the adios-documentation branch from 0a71182 to a5c0f88 Compare June 5, 2025 21:56
@saschjmil saschjmil added the enhancement New feature or request label Jun 6, 2025
@saschjmil
Copy link
Contributor

This is great, thanks so much for doing this! It looks like the PR Conventional Commit Validation check is failing because it can't run on your fork. I'll need to look into that, but it shouldn't block this PR. I've added the enhancement label to match the conventional commit prefix.

cebald added 10 commits June 9, 2025 16:57
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
…acts

Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
…rated overview from networking impacts

Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
@cebaldauff cebaldauff force-pushed the adios-documentation branch from 90e2041 to 093e274 Compare June 9, 2025 20:58
@cebaldauff cebaldauff changed the title feat: line by line documentation of DaC docs: line by line documentation of DaC Jun 9, 2025
Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for the thorough documentation!

@saschjmil saschjmil added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jun 9, 2025
Signed-off-by: Caroline Baldauff <caroline.baldauff@sas.com>
@PhanikumarThodupunoori
Copy link
Contributor

Thanks — the update looks good. Approving the PR now.

Co-authored-by: David Houck <dhoucgitter@users.noreply.github.com>
@saschjmil saschjmil merged commit 9d9eff6 into sassoftware:main Jun 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants