Skip to content

feat: add support for kubernetes 1.33 (PSCLOUD-76)#659

Merged
abhi44706 merged 9 commits intomainfrom
pr-pscloud-76
Aug 1, 2025
Merged

feat: add support for kubernetes 1.33 (PSCLOUD-76)#659
abhi44706 merged 9 commits intomainfrom
pr-pscloud-76

Conversation

@abhi44706
Copy link

@abhi44706 abhi44706 commented Jul 25, 2025

Changes

  • Updated default kubectl version to 1.32.6 in Dockerfile and docs
  • updated cert-manager chart version from 1.16.2 to 1.18.2
  • Adjusted ingress-nginx chart version logic to default to 4.13.0 for K8s >= 1.29.x
  • Updated cluster-autoscaler chart version to 9.48.0 for compatibility with newer K8s versions
  • added fix to handle UndefinedMarker errors in Ansible Jinja templates

Tests

Scenario DaC use method Provider K8s version metrics-server app_version cluster-autoscaler app_version Order Cadence Postgres Notes
1 local ansible AWS 1.31 0.7.2 1.32.0 * stable:2025.06 Crunchy Successful baseline install of metrics-server and cluster-autoscaler at recorded app_version, successful Viya install with all pods Running and stable
2 docker container AWS 1.32 0.7.2 1.32.0 * stable:2025.06 Crunchy Successful baseline install of metrics-server and cluster-autoscaler at the indicated app_versions, Successful Viya deployment, all pods Running. Successful login to Viya app as viya_admin. Successful creation of SAS Studio context in SAS Studio app.
3 docker container Azure 1.33 n/a n/a * stable:2025.06 Crunchy/External Verified successful deployment operator deployment with kubectl 1.32.6 version override. Successful login to Viya as viya_admin to landing page. Successful creation of SAS Studio context in SAS Studio app.
4 docker container GCP 1.32 n/a n/a * stable:2025.03 Crunchy/External Verified successful deploy command deployment. Successful login to Viya as viya_admin to landing page. Successful creation of SAS Studio context in SAS Studio app.

@github-actions github-actions bot added the enhancement New feature or request label Jul 25, 2025
Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. The ansible-lint linter is failing so that will need to be addressed. Could you add your testing scenarios to the PR description? Something like #621.

Also, I'm concerned about the INGRESS_NGINX_CHART_VERSION changes.

@saschjmil saschjmil requested a review from dhoucgitter July 28, 2025 21:23
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my version suggestions surrounding the CONFIG-VARS.md version values
since you'll want to use 4.13.0 for k8s 1.29 or newer clusters and you'd need the customer to specify which ingress-nginx version to use for anything at k8s 1.28 or older. Also, the intent is for no versions to exist between the last two >= and <= values in the sentence.

Also wondering what made the chartVersionMin change from 4.0.17 to 4.12.0 necessary?

@dhoucgitter
Copy link
Member

dhoucgitter commented Aug 1, 2025

@abhi44706 , should the Changes comment in the list above say " for K8s >=1.29.x" ?

Adjusted ingress-nginx chart version logic to default to 4.13.0 for K8s >= 1.31.x

Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see my comment re: K8s version for ingress-nginx in the Changes summary.

@abhi44706 abhi44706 merged commit 389a035 into main Aug 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants