feat: add support for kubernetes 1.33 (PSCLOUD-76)#659
Conversation
saschjmil
left a comment
There was a problem hiding this comment.
This is looking good. The ansible-lint linter is failing so that will need to be addressed. Could you add your testing scenarios to the PR description? Something like #621.
Also, I'm concerned about the INGRESS_NGINX_CHART_VERSION changes.
dhoucgitter
left a comment
There was a problem hiding this comment.
See my version suggestions surrounding the CONFIG-VARS.md version values
since you'll want to use 4.13.0 for k8s 1.29 or newer clusters and you'd need the customer to specify which ingress-nginx version to use for anything at k8s 1.28 or older. Also, the intent is for no versions to exist between the last two >= and <= values in the sentence.
Also wondering what made the chartVersionMin change from 4.0.17 to 4.12.0 necessary?
Co-authored-by: David Houck <dhoucgitter@users.noreply.github.com>
|
@abhi44706 , should the Changes comment in the list above say " for K8s >=1.29.x" ?
|
dhoucgitter
left a comment
There was a problem hiding this comment.
LGTM, see my comment re: K8s version for ingress-nginx in the Changes summary.
Changes
Tests