Skip to content

fix: conditionally set ingress-nginx chart version based on cadence and K8s minor version (PSCLOUD-99)#666

Merged
abhi44706 merged 3 commits intomainfrom
pr-pscloud-99
Aug 13, 2025
Merged

fix: conditionally set ingress-nginx chart version based on cadence and K8s minor version (PSCLOUD-99)#666
abhi44706 merged 3 commits intomainfrom
pr-pscloud-99

Conversation

@abhi44706
Copy link

@abhi44706 abhi44706 commented Aug 12, 2025

Changes

  • This PR implements conditional logic to set INGRESS_NGINX_CHART_VERSION based on V4_CFG_CADENCE_VERSION when the Kubernetes minor version is greater than or equal to the defined threshold (ingressVersions.k8sMinorVersion.value).
  • If K8s minor ≥ threshold:
    • Cadence ≤ 2025.07 → 4.12.1
    • Cadence ≥ 2025.08 → 4.13.0
  • If K8s minor < threshold:
    • Leave empty ("")
  • User-defined INGRESS_NGINX_CHART_VERSION in ansible-var.yaml will always take precedence.

Test Scenarios:

  • K8s minor ≥ 33 & Cadence ≥ 2025.08 → INGRESS_NGINX_CHART_VERSION = 4.13.0 ✅ Passed
  • K8s minor ≥ threshold & Cadence ≥ 2025.08 → INGRESS_NGINX_CHART_VERSION = 4.13.0 ✅ Passed
  • K8s minor ≥ threshold & Cadence ≤ 2025.07 → INGRESS_NGINX_CHART_VERSION = 4.12.1 ✅ Passed
  • User-defined INGRESS_NGINX_CHART_VERSION in ansible-var.yaml → Retained as-is ✅ Passed

@github-actions github-actions bot added the bug Something isn't working label Aug 12, 2025
@abhi44706 abhi44706 marked this pull request as draft August 12, 2025 12:30
@abhi44706 abhi44706 marked this pull request as ready for review August 12, 2025 14:13
Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhi44706 abhi44706 merged commit fe17f77 into main Aug 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants