fix: set ingress-nginx chart version dynamically based on cadence version#668
Merged
fix: set ingress-nginx chart version dynamically based on cadence version#668
Conversation
abhi44706
commented
Aug 19, 2025
abhi44706
commented
- revert dynamic ingress-nginx version logic as fix is available in ingress controller
reverting conditional check as this is no more required
revert docs changes for ingress-nignix
fix: indentation issues
abhi44706
changed the title
niraj2347
approved these changes
Aug 19, 2025
lohitdave
approved these changes
Aug 19, 2025
Updated INGRESS_NGINX_CHART_VERSION documentation to reflect Kubernetes version handling, cadence-based chart support (≤2025.07 uses 4.12.0, ≥2025.08 supports 1.13.x).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.