fix: contour network mapping#690
Merged
abhikumar2204 merged 1 commit intosassoftware:mainfrom Nov 10, 2025
Merged
Conversation
Signed-off-by: Eric Bourn <eric.bourn@sas.com>
abhikumar2204
changed the title
umeshk20
approved these changes
Nov 10, 2025
Contributor
umeshk20
left a comment
umeshk20
left a comment
There was a problem hiding this comment.
Looks good to me.
Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the value used for the Contour network mapping.
The value should be "projectcontour.io" and not "projectcountour.io".
This is causing the wrong overlay value to get inserted into the kustomization.yaml when DaC deploys Contour as the ingress. Note that within a deployment's sas-bases directory, it is:
{deploy-dir}/sas-bases/overlays/network/projectcontour.io