Alerting samples

[ceelias]

No description provided.

[gsmith-sas]

Need to add an entry for this to the CHANGELOG.md. I guess it be classified as a CHANGE and indicate that we've decided it was better to deliver alerts as samples rather than deploying them automatically...to allow sites to customize them as needed. Not sure what else we need/want to say about it. Probably should mention that we "fixed" some of the alert definitions that were broken.

Hmmm, for sites that are doing an update-in-place, I guess any previously deployed alerts will stay deployed. I guess that's fine; if they're happy with them, there's no reason for us to uninstall them. Mentioning that we fixed some of the alerts in the CHANGELOG should prompt them to consider redeploying the updated versions.

[github-actions]

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck -e SC1004' found no issues.

shfmt errors

'shfmt -s -i 4 -bn -sr -ln bash' returned error 1 finding the following formatting issues:

----------
diff monitoring/bin/deploy_monitoring_cluster.sh.orig monitoring/bin/deploy_monitoring_cluster.sh
--- monitoring/bin/deploy_monitoring_cluster.sh.orig
+++ monitoring/bin/deploy_monitoring_cluster.sh
@@ -380,7 +380,7 @@
 log_verbose "Creating Grafana alert rules ConfigMap"
 CUSTOM_ALERT_CONFIG_DIR="$USER_DIR/monitoring/alerting/"
 
-if [ -d "$CUSTOM_ALERT_CONFIG_DIR" ] && [ "$(ls -A "$CUSTOM_ALERT_CONFIG_DIR" 2>/dev/null)" ]; then
+if [ -d "$CUSTOM_ALERT_CONFIG_DIR" ] && [ "$(ls -A "$CUSTOM_ALERT_CONFIG_DIR" 2> /dev/null)" ]; then
     log_debug "Creating configmap for alert rules/notifiers/contact points defined in '$CUSTOM_ALERT_CONFIG_DIR'"
     CM_ARGS=(--from-file="$CUSTOM_ALERT_CONFIG_DIR")
 
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt -s -i 4 -bn -sr -ln bash -w filename

[github-actions]

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck -e SC1004' found no issues.

shfmt errors

'shfmt -s -i 4 -bn -sr -ln bash' returned error 1 finding the following formatting issues:

----------
diff monitoring/bin/deploy_monitoring_cluster.sh.orig monitoring/bin/deploy_monitoring_cluster.sh
--- monitoring/bin/deploy_monitoring_cluster.sh.orig
+++ monitoring/bin/deploy_monitoring_cluster.sh
@@ -380,7 +380,7 @@
 log_verbose "Creating Grafana alert rules ConfigMap"
 CUSTOM_ALERT_CONFIG_DIR="$USER_DIR/monitoring/alerting/"
 
-if [ -d "$CUSTOM_ALERT_CONFIG_DIR" ] && [ "$(ls -A "$CUSTOM_ALERT_CONFIG_DIR" 2>/dev/null)" ]; then
+if [ -d "$CUSTOM_ALERT_CONFIG_DIR" ] && [ "$(ls -A "$CUSTOM_ALERT_CONFIG_DIR" 2> /dev/null)" ]; then
     log_debug "Creating configmap for alert rules/notifiers/contact points defined in '$CUSTOM_ALERT_CONFIG_DIR'"
     CM_ARGS=(--from-file="$CUSTOM_ALERT_CONFIG_DIR")
 
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt -s -i 4 -bn -sr -ln bash -w filename

[github-actions]

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck -e SC1004' found no issues.

shfmt errors

'shfmt -s -i 4 -bn -sr -ln bash' returned error 1 finding the following formatting issues:

----------
diff monitoring/bin/deploy_monitoring_cluster.sh.orig monitoring/bin/deploy_monitoring_cluster.sh
--- monitoring/bin/deploy_monitoring_cluster.sh.orig
+++ monitoring/bin/deploy_monitoring_cluster.sh
@@ -380,7 +380,7 @@
 log_verbose "Creating Grafana alert rules ConfigMap"
 CUSTOM_ALERT_CONFIG_DIR="$USER_DIR/monitoring/alerting/"
 
-if [ -d "$CUSTOM_ALERT_CONFIG_DIR" ] && [ "$(ls -A "$CUSTOM_ALERT_CONFIG_DIR" 2>/dev/null)" ]; then
+if [ -d "$CUSTOM_ALERT_CONFIG_DIR" ] && [ "$(ls -A "$CUSTOM_ALERT_CONFIG_DIR" 2> /dev/null)" ]; then
     log_debug "Creating configmap for alert rules/notifiers/contact points defined in '$CUSTOM_ALERT_CONFIG_DIR'"
     CM_ARGS=(--from-file="$CUSTOM_ALERT_CONFIG_DIR")
 
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt -s -i 4 -bn -sr -ln bash -w filename

[gsmith-sas]

Looks good. I only have a few suggestions for tweaks to the CHANGELOG.md entry.

[gsmith-sas]

LGTM