chore: respond to code review

Signed-off-by: Scott Dover <[email protected]>

Author: Scott Dover

client/src/components/LibraryNavigator/LibraryModel.ts

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 import { ProgressLocation, l10n, window } from "vscode";
 
-import { SortModelItem } from "ag-grid-community";
+import type { SortModelItem } from "ag-grid-community";
 import { Writable } from "stream";
 
 import PaginatedResultSet from "./PaginatedResultSet";

client/src/components/LibraryNavigator/PaginatedResultSet.ts

@@ -1,6 +1,6 @@
 // Copyright © 2023, SAS Institute Inc., Cary, NC, USA.  All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
-import { SortModelItem } from "ag-grid-community";
+import type { SortModelItem } from "ag-grid-community";
 
 class PaginatedResultSet<T> {
   constructor(

client/src/components/LibraryNavigator/types.ts

@@ -1,6 +1,6 @@
 // Copyright © 2023, SAS Institute Inc., Cary, NC, USA.  All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
-import { SortModelItem } from "ag-grid-community";
+import type { SortModelItem } from "ag-grid-community";
 
 import { ColumnCollection, TableInfo } from "../../connection/rest/api/compute";
 

client/src/connection/itc/ItcLibraryAdapter.ts

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 import { l10n } from "vscode";
 
-import { SortModelItem } from "ag-grid-community";
+import type { SortModelItem } from "ag-grid-community";
 import { ChildProcessWithoutNullStreams } from "child_process";
 
 import { onRunError } from "../../commands/run";

client/src/connection/itc/script.ts

@@ -303,7 +303,7 @@ class SASRunner{
     Write-Host $(ConvertTo-Json -Depth 10 -InputObject $result -Compress)
   }
 
-  [object[]] GetColumnData([string]$libname, [string]$memname) {
+  [void]GetColumns([string]$libname, [string]$memname) {
     $objRecordSet = New-Object -comobject ADODB.Recordset
     $objRecordSet.ActiveConnection = $this.dataConnection
     $query = @"
@@ -338,12 +338,6 @@ class SASRunner{
       $parsedRows += $parsedRow
     }
 
-    return $parsedRows
-  }
-
-  [void]GetColumns([string]$libname, [string]$memname) {
-    $parsedRows = $this.GetColumnData($libname, $memname)
-
     Write-Host $(ConvertTo-Json -Depth 10 -InputObject $parsedRows -Compress)
   }
 
@@ -606,7 +600,7 @@ class SASRunner{
     $objRecordSet = New-Object -comobject ADODB.Recordset
     $objRecordSet.ActiveConnection = $this.dataConnection
     $query = @"
-      select memname, memtype, crdate, modate, nobs, nvar, compress, 
+      select memname, memtype, crdate, modate, nobs, nvar, compress,
              memlabel, typemem, filesize, delobs
       from sashelp.vtable
       where libname='$libname' and memname='$memname';

client/src/connection/rest/RestLibraryAdapter.ts

@@ -1,6 +1,6 @@
 // Copyright © 2024, SAS Institute Inc., Cary, NC, USA.  All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
-import { SortModelItem } from "ag-grid-community";
+import type { SortModelItem } from "ag-grid-community";
 import { AxiosResponse } from "axios";
 
 import { getSession } from "..";