fix: allow bracket matching in macro quote #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Wu <[email protected]>
scnjdl
approved these changes
Oct 24, 2024
enzhihpp
assigned
tianliang657,
ShermanWang0324 and
Zhirong2022 and unassigned
enzhihpp,
tianliang657 and
ShermanWang0324
Zhirong2022
added
testing
|
It has correct bracket matching and highlighting. |
Zhirong2022
added
testing-complete
Zhirong2022
approved these changes
Oct 25, 2024
Zhirong2022
added
ready for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1213
VS Code will NOT match brackets in strings. Macro quote doesn't need to be treated as string.
Testing
Test case in #1213