fix: use vscode.open to open file

[scnwwu]

Summary
Fix #1289
Need to use vscode.open to open file with correct UI instead of always opening with the default code editor.
It looks like the reason using vscode.openWith was to set preview to false. In my opinion we should not always set preview to false. It's possible that the file was in preview mode before closing, in which case it doesn't make sense to re-open with preview: false. The tab closing is noticeable to end user. We even ask user to save or not save the file before closing. So I think it's OK to re-open with preview mode, same as if user close and re-open.

Testing
Test case in #1289

[scottdover]

I switched to using openWith in my latest changes because renaming a folder requires closing all files within the folder (for sas server, where the uris change as part of renaming). This change would effectively make it such that we close N files (where N > 1) but only re-open 1 file (unless preview mode is disabled)

[scnwwu]

I switched to using openWith in my latest changes because renaming a folder requires closing all files within the folder (for sas server, where the uris change as part of renaming). This change would effectively make it such that we close N files (where N > 1) but only re-open 1 file (unless preview mode is disabled)

Hi @scottdover, I tried with this PR, it successfully re-opened all closed files. When calling vscode.open the second time, the first opened tab was made non-preview automatically. Would you double check?

[scottdover]

You're right 🤔 . I was pretty certain I tested re-opening multiple files after renaming the folder and it didn't work with preview mode...must've been something else causing my issue. Thanks for taking care of this :)

[ShermanWang0324]

Tested the rename sas notebook file with unsaved sas code, re-render will successful as expected.