Skip to content

Conversation

@scnwwu
Copy link
Contributor

@scnwwu scnwwu commented Nov 29, 2024

Summary
Fix #1301
Add sas2py as built-in stub

Testing
Test case in #1301

@scnwwu scnwwu changed the title fix: support SAS module in PROC PYTHON fix: support SAS module help in PROC PYTHON Nov 29, 2024
@scnwwu scnwwu requested review from boyce-w and scnjdl November 29, 2024 02:19
@scnwwu scnwwu added this to the 1.13.0 milestone Nov 29, 2024
@enzhihpp enzhihpp assigned ShermanWang0324 and unassigned enzhihpp Nov 29, 2024
@ShermanWang0324 ShermanWang0324 added testing Test the pull requests and removed verification-needed labels Nov 29, 2024
@ShermanWang0324
Copy link
Collaborator

Run the code from #1301, the previous error is gone, but got the new error message as
Screenshot 2024-12-02 165439

@scnwwu
Copy link
Contributor Author

scnwwu commented Dec 3, 2024

Run the code from #1301, the previous error is gone, but got the new error message as

Fixed. Please re-test. Thanks.

@ShermanWang0324 ShermanWang0324 added testing-complete Complete the pull requests testing and removed testing Test the pull requests labels Dec 3, 2024
@ShermanWang0324
Copy link
Collaborator

No problems have been detected in the workplace now

@scnwwu scnwwu merged commit 95794c6 into sassoftware:main Dec 3, 2024
2 checks passed
@scnwwu scnwwu deleted the p-pythonsas branch December 3, 2024 09:11
@ShermanWang0324 ShermanWang0324 added ready for release Code pushed, but not released in VS code marketplace yet and removed testing-complete Complete the pull requests testing labels Dec 20, 2024
@Zhirong2022 Zhirong2022 added the automation Issue has been covered by automation test label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Issue has been covered by automation test ready for release Code pushed, but not released in VS code marketplace yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It will show the error "SAS" is not defined on problem panel

5 participants