Skip to content

Conversation

@kpatl1
Copy link
Collaborator

@kpatl1 kpatl1 commented Sep 12, 2025

Summary
This PR implements dataset properties functionality for the VSCode extension, bringing feature parity with SasStudio online version. Users can now right-click on datasets in the Library Navigator and view comprehensive metadata including creation dates, modification dates, dataset labels, compression information, and detailed column information.

Testing
Went into SASStudio and viewed properties for identical datasets and made sure that the information matched.

Fixes #1537

@kpatl1 kpatl1 requested review from scnwwu and removed request for scnwwu September 12, 2025 20:33
@kpatl1 kpatl1 marked this pull request as ready for review September 15, 2025 19:08
@kpatl1 kpatl1 requested a review from scnwwu September 15, 2025 19:08
@kpatl1 kpatl1 assigned kpatl1 and unassigned kpatl1 Sep 15, 2025
@kpatl1 kpatl1 requested a review from scottdover September 15, 2025 19:53
@scnwwu
Copy link
Contributor

scnwwu commented Sep 18, 2025

Overall looks good to me. Will defer to @scottdover to approve. Thanks.

@snlwih
Copy link

snlwih commented Oct 8, 2025

@kpatl1 , have you considered having an option inside table viewer to see that same/similar info directly without having to leave the table viewer panel? Agreed that this is a nice-to-have, but just wondering what it would take to have this option in table viewer. Especially now we're working on adding additional capabilities in table viewer.

Copy link
Contributor

@scottdover scottdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Only had a couple minor things to mention

@scottdover scottdover mentioned this pull request Oct 20, 2025
10 tasks
Signed-off-by: Kishan Patel <[email protected]>
@kpatl1 kpatl1 merged commit e8c5a1e into main Oct 22, 2025
2 checks passed
@kpatl1 kpatl1 deleted the feat/kpatl-1537 branch October 22, 2025 16:51
@scottdover
Copy link
Contributor

Hey @enzhihpp . These changes were accidentally merged prior to testing. Can we get this tested and perhaps create additional bugs for things that are oustanding?

@scottdover scottdover added this to the 1.18.0 milestone Oct 22, 2025
@enzhihpp enzhihpp assigned Zhirong2022 and unassigned enzhihpp Oct 23, 2025
@enzhihpp
Copy link

Hey @enzhihpp . These changes were accidentally merged prior to testing. Can we get this tested and perhaps create additional bugs for things that are oustanding?

Yes, we will do that.

@Zhirong2022 Zhirong2022 added testing Test the pull requests and removed verification-needed labels Oct 23, 2025
@Zhirong2022
Copy link

Please check the raised issue #1674, #1675, #1676, #1677.

@Zhirong2022 Zhirong2022 added testing-complete Complete the pull requests testing and removed testing Test the pull requests labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing-complete Complete the pull requests testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Libraries panel: Add option to view table properties and its column details

7 participants