-
Notifications
You must be signed in to change notification settings - Fork 62
feat(LibraryNavigator): added ability to view dataset properties #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kishan Patel <[email protected]>
Signed-off-by: Kishan Patel <[email protected]>
Signed-off-by: Kishan Patel <[email protected]>
Signed-off-by: Kishan Patel <[email protected]>
|
Overall looks good to me. Will defer to @scottdover to approve. Thanks. |
|
@kpatl1 , have you considered having an option inside table viewer to see that same/similar info directly without having to leave the table viewer panel? Agreed that this is a nice-to-have, but just wondering what it would take to have this option in table viewer. Especially now we're working on adding additional capabilities in table viewer. |
scottdover
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Only had a couple minor things to mention
Signed-off-by: Kishan Patel <[email protected]>
|
Hey @enzhihpp . These changes were accidentally merged prior to testing. Can we get this tested and perhaps create additional bugs for things that are oustanding? |
Yes, we will do that. |
Summary
This PR implements dataset properties functionality for the VSCode extension, bringing feature parity with SasStudio online version. Users can now right-click on datasets in the Library Navigator and view comprehensive metadata including creation dates, modification dates, dataset labels, compression information, and detailed column information.
Testing
Went into SASStudio and viewed properties for identical datasets and made sure that the information matched.
Fixes #1537