Skip to content

feat: R syntax highlighting and Notebook Support #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Wizzzzzzard wants to merge 28 commits into
base: main
Choose a base branch
from
Open

feat: R syntax highlighting and Notebook Support #1719

Wizzzzzzard wants to merge 28 commits into from

Conversation

@Wizzzzzzard
Copy link
Member

@Wizzzzzzard Wizzzzzzard commented Dec 4, 2025 •
edited
Loading

Summary:
This PR adds initial support for the R language (via PROC RLANG), equivalent to the existing support for Python (PROC PYTHON) and Lua (PROC LUA).

Addresses #1572

Testing:

  • Lexer Tests: Verified PROC RLANG code zones are properly detected (4 passing tests)
  • Client Tests: Verified R code wrapping and notebook cell handling (146 passing tests)
  • Formatter Tests: Verified R code preservation in formatter expected outputs
  • Manual Testing:
    • Created R code cells in SAS Notebooks
    • Exported notebooks to SAS and verified PROC RLANG generation
    • Exported notebooks to HTML and verified R syntax highlighting
    • Tested formatter preserves R code formatting
    • Verified backward compatibility with existing "rlang" language ID

TODOs:

  • Add R language support to lexer/parser
  • Add R support to SAS Notebooks (cells, export)
  • Add R syntax highlighting via embeddedLanguages
  • Add formatter preservation for R code blocks
  • Add test coverage (server and client)
  • Update documentation (README, website docs, CHANGELOG)
  • Verify backward compatibility with existing notebooks
  • Test all export formats (SAS, HTML)

Future Enhancements (Not in this PR):

  • R Language Server integration for IntelliSense (autocomplete, hover, diagnostics) - similar to Pyright for Python
    • Note: This would be moderately complex to implement as most R language servers require the R runtime environment, making browser support challenging

@Wizzzzzzard
initial commit of proc_r embedded lang test
416922d
@Wizzzzzzard
adding R language options to client and notebook
74a5d31
@Wizzzzzzard
adding some R Code test fixtures
0231587
@Wizzzzzzard
fixing rlang testfixture file name
8f22394
@Wizzzzzzard
adding a print statement to debug rlang zonelist
97489e5
@Wizzzzzzard
updating debug function for zone_type assertions
696bddd
@Wizzzzzzard
DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzza…
a05b28f 
…[email protected]>

I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 416922d
I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 74a5d31
I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 0231587
I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 8f22394
I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 97489e5
I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 696bddd

Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
Updating Lexer to correctly parse PROC RLANG code
29dfd9a
@Wizzzzzzard
Adding PROC_RLANG to CodeZoneManager
0e2b746
@Wizzzzzzard
Adding R as an option to the parser for formatting
398c156
@Wizzzzzzard
DCO Remediation Commit for Elijah Cúchulainn Reid <56865341+Wizzzzzza…
ca52898 
…[email protected]>

I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 29dfd9a
I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 0e2b746
I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 398c156

Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
test with simpler rlang script
454a6ab
@Wizzzzzzard
resetting to more complex Rlang file
5e4da15 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
fixing file
a3be20b 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
adding more rlang tests to match pre-existing lua and python ones
412995f 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
reverting embedded lang test assert for rlang
e62c8e8 
DCO Remediation Commit for Elijah Cúchulainn Reid <[email protected]>

I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: 454a6ab

Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
updating references to "rlang" as a language to "r" to work better wi…
c5f8f7f 
…th VS Code's language server
@Wizzzzzzard
making spacing a bit nicer
d4da7ad 
DCO Remediation Commit for Elijah Cúchulainn Reid <[email protected]>

I, Elijah Cúchulainn Reid <[email protected]>, hereby add my Signed-off-by to this commit: c5f8f7f

Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
tweaking R UID to see if it makes a difference
7e58b1c 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
Updating notebook with correctly highlighted R code
925ff77 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
uploading notebook with R output
9e1b66a 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
making the rlang id match python
3b41802 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
Updating references to languages in docs to include R
54f72e3 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard
Including R changes in the Changelog
82d5f26 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
@Wizzzzzzard Wizzzzzzard changed the title initial commit of proc_r embedded lang test feat: R syntax highlighting and Notebook Support Dec 5, 2025
scottdover
scottdover reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

@scottdover scottdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor comments

@Wizzzzzzard Wizzzzzzard marked this pull request as ready for review December 5, 2025 15:45
@Wizzzzzzard
Copy link
Member Author

Wizzzzzzard commented Dec 5, 2025

Only a few minor comments

@scottdover I've actioned your comments now so should be good for reviews from you and the other maintainers :)

@Wizzzzzzard
updating Code Document to only require r
4036233 
Signed-off-by: Elijah Cúchulainn Reid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottdover scottdover Awaiting requested review from scottdover

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

verification-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wizzzzzzard @scottdover