Skip to content

fix: fix misc selection issues#1748

Merged
scottdover merged 2 commits intomainfrom
fix/1744-treeview-selection
Feb 13, 2026
Merged

fix: fix misc selection issues#1748
scottdover merged 2 commits intomainfrom
fix/1744-treeview-selection

Conversation

@scottdover
Copy link
Contributor

@scottdover scottdover commented Jan 7, 2026

Summary:
This does a few things around improving context menus and selections.

  • It disables the command palette for things that shouldn't work in that way
  • It removes context menu items that are being displayed for multiple item selection (although they should only be for single item selection)
  • It updates tree view selection to work in the way described in Fix treeview selection #1744

NOTE: The most ideal path here imo is to automatically select an item when issuing the context menu (if it isn't part of the selections). I looked for a way to handle that but was unable. This change seems to work similar to how vscode does things natively.

Testing:

  • Made sure things displayed in the command palette worked as expected
  • Made sure selection worked as expected

Signed-off-by: Scott Dover <Scott.Dover@sas.com>
@scottdover scottdover linked an issue Jan 7, 2026 that may be closed by this pull request
@scottdover scottdover requested review from IreneS1 and smorrisj January 8, 2026 14:04
@scottdover scottdover marked this pull request as ready for review January 8, 2026 14:04
Signed-off-by: Scott Dover <Scott.Dover@sas.com>
@dahils dahils added testing Test the pull requests testing-complete Complete the pull requests testing and removed verification-needed testing Test the pull requests labels Feb 12, 2026
@dahils dahils assigned scottdover and unassigned dahils Feb 12, 2026
@scottdover scottdover added this to the 1.19.0 milestone Feb 13, 2026
@scottdover scottdover merged commit fc064f7 into main Feb 13, 2026
3 of 4 checks passed
@scottdover scottdover deleted the fix/1744-treeview-selection branch February 13, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing-complete Complete the pull requests testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix treeview selection

4 participants