Merged
Conversation
Summary: Provided better definition for providing a full path definition of the fileName value for SAS Server file system which eventually will get defined in the _SASPROGRAMFILE macro definition in the wrapper code which gets submitted with each run. Testing: There are already test cases defined to exercise the fileName value. Tested against IOM and Viya and local File system. SSH not applicable. Signed-off-by: MIKE PORTER <mike.porter@sas.com>
scottdover
reviewed
Feb 3, 2026
added 4 commits
February 3, 2026 10:38
- address code review suggestions
Summary: Provided better definition for providing a full path definition of the fileName value for SAS Server file system which eventually will get defined in the _SASPROGRAMFILE macro definition in the wrapper code which gets submitted with each run. Testing: There are already test cases defined to exercise the fileName value. Tested against IOM and Viya and local File system. SSH not applicable. Signed-off-by: MIKE PORTER <mike.porter@sas.com>
DCO Remediation Commit for MIKE PORTER <mike.porter@sas.com> I, MIKE PORTER <mike.porter@sas.com>, hereby add my Signed-off-by to this commit: ecc25a8 Signed-off-by: MIKE PORTER <mike.porter@sas.com>
Signed-off-by: MIKE PORTER <mike.porter@sas.com>
scottdover
approved these changes
Feb 4, 2026
|
@mikewporter / @scottdover , sounds like "it's almost there" and therefore should already be added to milestone 1.19? |
dahils
added
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Provided better definition for providing a full path definition of the fileName value for SAS Server file system which eventually will get defined in the _SASPROGRAMFILE macro definition in the wrapper code which gets submitted with each run.
Testing:
There are already test cases defined to exercise the fileName value. Tested against IOM and Viya and local File system. SSH not applicable.
Local Files and IOM based files server files will return the full path.
Viya Server files will define the relative path to home.
In addition to testing the output of the MACRO value, consider also testing: